Commit f20ee83e authored by Denys Mishunov's avatar Denys Mishunov

Merge branch 'wiki-header-spacing' into 'master'

Standardize wiki header spacing

See merge request gitlab-org/gitlab!49777
parents 2298c1b2 aba98c58
...@@ -15,11 +15,6 @@ ...@@ -15,11 +15,6 @@
padding: 11px 0; padding: 11px 0;
} }
.wiki-page-title {
margin: 0;
font-size: 22px;
}
.wiki-last-edit-by { .wiki-last-edit-by {
display: block; display: block;
color: var(--gray-500, $gray-500); color: var(--gray-500, $gray-500);
......
...@@ -5,8 +5,7 @@ ...@@ -5,8 +5,7 @@
.wiki-page-header.top-area.has-sidebar-toggle.flex-column.flex-lg-row .wiki-page-header.top-area.has-sidebar-toggle.flex-column.flex-lg-row
= wiki_sidebar_toggle_button = wiki_sidebar_toggle_button
.nav-text %h3.page-title.gl-flex-fill-1
%h2.wiki-page-title
= link_to_wiki_page @page = link_to_wiki_page @page
%span.light %span.light
· ·
......
...@@ -6,8 +6,7 @@ ...@@ -6,8 +6,7 @@
.wiki-page-header.top-area.has-sidebar-toggle.flex-column.flex-lg-row .wiki-page-header.top-area.has-sidebar-toggle.flex-column.flex-lg-row
= wiki_sidebar_toggle_button = wiki_sidebar_toggle_button
.nav-text %h3.page-title.gl-flex-fill-1
%h2.wiki-page-title
- if @page.persisted? - if @page.persisted?
= link_to_wiki_page @page = link_to_wiki_page @page
%span.light %span.light
......
...@@ -4,8 +4,7 @@ ...@@ -4,8 +4,7 @@
.wiki-page-header.top-area.has-sidebar-toggle.flex-column.flex-lg-row .wiki-page-header.top-area.has-sidebar-toggle.flex-column.flex-lg-row
= wiki_sidebar_toggle_button = wiki_sidebar_toggle_button
.nav-text %h3.page-title
%h2.wiki-page-title
= link_to_wiki_page @page = link_to_wiki_page @page
%span.light %span.light
· ·
......
...@@ -6,8 +6,8 @@ ...@@ -6,8 +6,8 @@
.wiki-page-header.top-area.flex-column.flex-lg-row .wiki-page-header.top-area.flex-column.flex-lg-row
.nav-text.flex-fill
%h2.wiki-page-title %h3.page-title.gl-flex-fill-1
= s_("Wiki|Wiki Pages") = s_("Wiki|Wiki Pages")
.nav-controls.pb-md-3.pb-lg-0 .nav-controls.pb-md-3.pb-lg-0
......
---
title: Standardize page title styles on all wiki pages
merge_request: 49777
author:
type: changed
...@@ -79,7 +79,7 @@ RSpec.shared_examples 'User creates wiki page' do ...@@ -79,7 +79,7 @@ RSpec.shared_examples 'User creates wiki page' do
expect(current_path).to eq(wiki_page_path(wiki, "test")) expect(current_path).to eq(wiki_page_path(wiki, "test"))
page.within(:css, ".nav-text") do page.within(:css, ".wiki-page-header") do
expect(page).to have_content("Create New Page") expect(page).to have_content("Create New Page")
end end
...@@ -91,7 +91,7 @@ RSpec.shared_examples 'User creates wiki page' do ...@@ -91,7 +91,7 @@ RSpec.shared_examples 'User creates wiki page' do
expect(current_path).to eq(wiki_page_path(wiki, "api")) expect(current_path).to eq(wiki_page_path(wiki, "api"))
page.within(:css, ".nav-text") do page.within(:css, ".wiki-page-header") do
expect(page).to have_content("Create") expect(page).to have_content("Create")
end end
...@@ -103,7 +103,7 @@ RSpec.shared_examples 'User creates wiki page' do ...@@ -103,7 +103,7 @@ RSpec.shared_examples 'User creates wiki page' do
expect(current_path).to eq(wiki_page_path(wiki, "raketasks")) expect(current_path).to eq(wiki_page_path(wiki, "raketasks"))
page.within(:css, ".nav-text") do page.within(:css, ".wiki-page-header") do
expect(page).to have_content("Create") expect(page).to have_content("Create")
end end
end end
......
...@@ -15,6 +15,6 @@ RSpec.shared_examples 'User uses wiki shortcuts' do ...@@ -15,6 +15,6 @@ RSpec.shared_examples 'User uses wiki shortcuts' do
it 'visit edit wiki page using "e" keyboard shortcut', :js do it 'visit edit wiki page using "e" keyboard shortcut', :js do
find('body').native.send_key('e') find('body').native.send_key('e')
expect(find('.wiki-page-title')).to have_content('Edit Page') expect(find('.page-title')).to have_content('Edit Page')
end end
end end
...@@ -44,7 +44,7 @@ RSpec.shared_examples 'User views a wiki page' do ...@@ -44,7 +44,7 @@ RSpec.shared_examples 'User views a wiki page' do
expect(current_path).to include('one/two/three-test') expect(current_path).to include('one/two/three-test')
page.within(:css, '.nav-text') do page.within(:css, '.wiki-page-header') do
expect(page).to have_content('History') expect(page).to have_content('History')
end end
end end
...@@ -69,7 +69,7 @@ RSpec.shared_examples 'User views a wiki page' do ...@@ -69,7 +69,7 @@ RSpec.shared_examples 'User views a wiki page' do
click_on('Page history') click_on('Page history')
within('.nav-text') do within('.wiki-page-header') do
expect(page).to have_content('History') expect(page).to have_content('History')
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment