Merge branch '201893-resolve-soft-email-confirmation-flow-3' into 'master'

Redirect to Almost there page when inactive after signing up

See merge request gitlab-org/gitlab!24462

app/controllers/registrations_controller.rb

@@ -117,8 +117,10 @@ class RegistrationsController < Devise::RegistrationsController
   end
 
   def after_inactive_sign_up_path_for(resource)
+    # With the current `allow_unconfirmed_access_for` Devise setting in config/initializers/8_devise.rb,
+    # this method is never called. Leaving this here in case that value is set to 0.
     Gitlab::AppLogger.info(user_created_message)
-    dashboard_projects_path
+    users_almost_there_path
   end
 
   private

spec/controllers/registrations_controller_spec.rb

@@ -77,10 +77,14 @@ describe RegistrationsController do
       context 'when send_user_confirmation_email is true' do
         before do
           stub_application_setting(send_user_confirmation_email: true)
+        end
+
+        context 'when a grace period is active for confirming the email address' do
+          before do
             allow(User).to receive(:allow_unconfirmed_access_for).and_return 2.days
           end
 
-        it 'authenticates the user and sends a confirmation email' do
+          it 'sends a confirmation email and redirects to the dashboard' do
             post(:create, params: user_params)
 
             expect(ActionMailer::Base.deliveries.last.to.first).to eq(user_params[:user][:email])
@@ -88,6 +92,20 @@ describe RegistrationsController do
           end
         end
 
+        context 'when no grace period is active for confirming the email address' do
+          before do
+            allow(User).to receive(:allow_unconfirmed_access_for).and_return 0
+          end
+
+          it 'sends a confirmation email and redirects to the almost there page' do
+            post(:create, params: user_params)
+
+            expect(ActionMailer::Base.deliveries.last.to.first).to eq(user_params[:user][:email])
+            expect(response).to redirect_to(users_almost_there_path)
+          end
+        end
+      end
+
       context 'when signup_enabled? is false' do
         it 'redirects to sign_in' do
           stub_application_setting(signup_enabled: false)