Commit f8c6fd18 authored by Rémy Coutable's avatar Rémy Coutable

Make 'review-deploy' depend on 'review-build-cng' with 'needs'

Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent e2ce3c1a
...@@ -126,7 +126,6 @@ review-build-cng: ...@@ -126,7 +126,6 @@ review-build-cng:
- .default-tags - .default-tags
- .default-retry - .default-retry
image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-charts-build-base image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-charts-build-base
dependencies: []
variables: variables:
HOST_SUFFIX: "${CI_ENVIRONMENT_SLUG}" HOST_SUFFIX: "${CI_ENVIRONMENT_SLUG}"
DOMAIN: "-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}" DOMAIN: "-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}"
...@@ -142,6 +141,9 @@ review-deploy: ...@@ -142,6 +141,9 @@ review-deploy:
- .review-workflow-base - .review-workflow-base
- .review:rules:mr-and-schedule - .review:rules:mr-and-schedule
stage: review stage: review
needs:
- job: review-build-cng
artifacts: false
allow_failure: true allow_failure: true
before_script: before_script:
- '[[ ! -d "ee/" ]] || export GITLAB_EDITION="ee"' - '[[ ! -d "ee/" ]] || export GITLAB_EDITION="ee"'
...@@ -169,6 +171,7 @@ review-deploy: ...@@ -169,6 +171,7 @@ review-deploy:
extends: .review-workflow-base extends: .review-workflow-base
environment: environment:
action: stop action: stop
dependencies: []
variables: variables:
# We're cloning the repo instead of downloading the script for now # We're cloning the repo instead of downloading the script for now
# because some repos are private and CI_JOB_TOKEN cannot access files. # because some repos are private and CI_JOB_TOKEN cannot access files.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment