Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f9e06537
Commit
f9e06537
authored
Oct 21, 2021
by
Sean Arnold
Committed by
Luke Duncalfe
Oct 21, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Quarantine flaky DST specs
parent
01079036
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
ee/spec/finders/incident_management/oncall_users_finder_spec.rb
...c/finders/incident_management/oncall_users_finder_spec.rb
+1
-1
ee/spec/services/incident_management/oncall_rotations/remove_participant_service_spec.rb
...ement/oncall_rotations/remove_participant_service_spec.rb
+2
-2
No files found.
ee/spec/finders/incident_management/oncall_users_finder_spec.rb
View file @
f9e06537
...
...
@@ -108,7 +108,7 @@ RSpec.describe IncidentManagement::OncallUsersFinder do
end
end
context
'with no persisted shifts for oncall_at time'
do
context
'with no persisted shifts for oncall_at time'
,
quarantine:
'https://gitlab.com/gitlab-org/gitlab/-/issues/343506'
do
let
(
:oncall_at
)
{
after_second_shift
}
it
{
is_expected
.
to
contain_exactly
(
user_1
,
user_2
,
user_4
)
}
...
...
ee/spec/services/incident_management/oncall_rotations/remove_participant_service_spec.rb
View file @
f9e06537
...
...
@@ -42,7 +42,7 @@ RSpec.describe IncidentManagement::OncallRotations::RemoveParticipantService do
# Create an historial shift (other participant)
let!
(
:historical_shift
)
{
create
(
:incident_management_oncall_shift
,
rotation:
rotation
,
participant:
other_participant
,
starts_at:
rotation
.
starts_at
,
ends_at:
ends_at
(
rotation
.
starts_at
))
}
context
'with historial and current shift'
do
context
'with historial and current shift'
,
quarantine:
'https://gitlab.com/gitlab-org/gitlab/-/issues/343506'
do
# Create a current shift (particpant being removed)
let!
(
:current_shift
)
{
create
(
:incident_management_oncall_shift
,
rotation:
rotation
,
participant:
participant
,
starts_at:
historical_shift
.
ends_at
,
ends_at:
ends_at
(
historical_shift
.
ends_at
))
}
...
...
@@ -63,7 +63,7 @@ RSpec.describe IncidentManagement::OncallRotations::RemoveParticipantService do
end
end
context
'when current shift has not been created'
do
context
'when current shift has not been created'
,
quarantine:
'https://gitlab.com/gitlab-org/gitlab/-/issues/343506'
do
it
'creates the current shift and cuts it short'
do
expect
{
execute
}.
to
change
{
rotation
.
shifts
.
count
}.
from
(
1
).
to
(
3
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment