Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
fbdec367
Commit
fbdec367
authored
Jan 17, 2022
by
Marius Bobin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove ci_archived_build_trace_checksum feature flag
Changelog: added
parent
aed836d7
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
17 deletions
+0
-17
config/feature_flags/development/ci_archived_build_trace_checksum.yml
...re_flags/development/ci_archived_build_trace_checksum.yml
+0
-8
lib/gitlab/ci/trace/remote_checksum.rb
lib/gitlab/ci/trace/remote_checksum.rb
+0
-1
spec/lib/gitlab/ci/trace/remote_checksum_spec.rb
spec/lib/gitlab/ci/trace/remote_checksum_spec.rb
+0
-8
No files found.
config/feature_flags/development/ci_archived_build_trace_checksum.yml
deleted
100644 → 0
View file @
aed836d7
---
name
:
ci_archived_build_trace_checksum
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/70072
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/340737
milestone
:
'
14.4'
type
:
development
group
:
group::pipeline execution
default_enabled
:
false
lib/gitlab/ci/trace/remote_checksum.rb
View file @
fbdec367
...
@@ -26,7 +26,6 @@ module Gitlab
...
@@ -26,7 +26,6 @@ module Gitlab
delegate
:aws?
,
:google?
,
to: :object_store_config
,
prefix: :provider
delegate
:aws?
,
:google?
,
to: :object_store_config
,
prefix: :provider
def
fetch_md5_checksum
def
fetch_md5_checksum
return
unless
Feature
.
enabled?
(
:ci_archived_build_trace_checksum
,
trace_artifact
.
project
,
default_enabled: :yaml
)
return
unless
object_store_config
.
enabled?
return
unless
object_store_config
.
enabled?
return
if
trace_artifact
.
local_store?
return
if
trace_artifact
.
local_store?
...
...
spec/lib/gitlab/ci/trace/remote_checksum_spec.rb
View file @
fbdec367
...
@@ -30,14 +30,6 @@ RSpec.describe Gitlab::Ci::Trace::RemoteChecksum do
...
@@ -30,14 +30,6 @@ RSpec.describe Gitlab::Ci::Trace::RemoteChecksum do
context
'with remote files'
do
context
'with remote files'
do
let
(
:file_store
)
{
JobArtifactUploader
::
Store
::
REMOTE
}
let
(
:file_store
)
{
JobArtifactUploader
::
Store
::
REMOTE
}
context
'when the feature flag is disabled'
do
before
do
stub_feature_flags
(
ci_archived_build_trace_checksum:
false
)
end
it
{
is_expected
.
to
be_nil
}
end
context
'with AWS as provider'
do
context
'with AWS as provider'
do
it
{
is_expected
.
to
eq
(
checksum
)
}
it
{
is_expected
.
to
eq
(
checksum
)
}
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment