Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
fc464f1f
Commit
fc464f1f
authored
May 04, 2017
by
Valery Sizov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Multiple issue assignee: fixed services/issues/update_service by using new NoteSummary
parent
0f2a9681
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
22 deletions
+1
-22
app/services/system_note_service.rb
app/services/system_note_service.rb
+1
-1
spec/features/boards/sidebar_spec.rb
spec/features/boards/sidebar_spec.rb
+0
-21
No files found.
app/services/system_note_service.rb
View file @
fc464f1f
...
@@ -84,7 +84,7 @@ module SystemNoteService
...
@@ -84,7 +84,7 @@ module SystemNoteService
"assigned to
#{
issue
.
assignees
.
map
(
&
:to_reference
).
to_sentence
}
"
"assigned to
#{
issue
.
assignees
.
map
(
&
:to_reference
).
to_sentence
}
"
end
end
create_note
(
noteable:
issue
,
project:
project
,
author:
author
,
note:
body
)
NoteSummary
.
new
(
issue
,
project
,
author
,
body
,
action:
'assignee'
)
end
end
# Called when one or more labels on a Noteable are added and/or removed
# Called when one or more labels on a Noteable are added and/or removed
...
...
spec/features/boards/sidebar_spec.rb
View file @
fc464f1f
...
@@ -21,7 +21,6 @@ describe 'Issue Boards', feature: true, js: true do
...
@@ -21,7 +21,6 @@ describe 'Issue Boards', feature: true, js: true do
Timecop
.
freeze
Timecop
.
freeze
project
.
team
<<
[
user
,
:master
]
project
.
team
<<
[
user
,
:master
]
project
.
team
.
add_developer
(
user2
)
login_as
(
user
)
login_as
(
user
)
...
@@ -103,26 +102,6 @@ describe 'Issue Boards', feature: true, js: true do
...
@@ -103,26 +102,6 @@ describe 'Issue Boards', feature: true, js: true do
expect
(
card
).
to
have_selector
(
'.avatar'
)
expect
(
card
).
to
have_selector
(
'.avatar'
)
end
end
it
'adds multiple assignees'
do
click_card
(
card
)
page
.
within
(
'.assignee'
)
do
click_link
'Edit'
wait_for_ajax
page
.
within
(
'.dropdown-menu-user'
)
do
click_link
user
.
name
click_link
user2
.
name
end
expect
(
page
).
to
have_content
(
user
.
name
)
expect
(
page
).
to
have_content
(
user2
.
name
)
end
expect
(
card
.
all
(
'.avatar'
).
length
).
to
eq
(
2
)
end
it
'removes the assignee'
do
it
'removes the assignee'
do
card_two
=
first
(
'.board'
).
find
(
'.card:nth-child(2)'
)
card_two
=
first
(
'.board'
).
find
(
'.card:nth-child(2)'
)
click_card
(
card_two
)
click_card
(
card_two
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment