Merge branch 'modify-update-runners-role' into 'master'

Adjust update_runners_registration_token permission

See merge request gitlab-org/gitlab!71965

app/policies/group_policy.rb

@@ -163,7 +163,6 @@ class GroupPolicy < BasePolicy
     enable :admin_cluster
     enable :read_deploy_token
     enable :create_jira_connect_subscription
-    enable :update_runners_registration_token
     enable :maintainer_access
   end
 
@@ -180,6 +179,7 @@ class GroupPolicy < BasePolicy
     enable :update_default_branch_protection
     enable :create_deploy_token
     enable :destroy_deploy_token
+    enable :update_runners_registration_token
     enable :owner_access
   end
 

spec/policies/group_policy_spec.rb

@@ -1005,7 +1005,7 @@ RSpec.describe GroupPolicy do
     context 'with maintainer' do
       let(:current_user) { maintainer }
 
-      it { is_expected.to be_allowed(:update_runners_registration_token) }
+      it { is_expected.to be_disallowed(:update_runners_registration_token) }
     end
 
     context 'with reporter' do

spec/requests/api/ci/runners_reset_registration_token_spec.rb

@@ -118,7 +118,7 @@ RSpec.describe API::Ci::Runners do
       end
 
       include_context 'when authorized', 'group' do
-        let_it_be(:user) { create_default(:group_member, :maintainer, user: create(:user), group: group ).user }
+        let_it_be(:user) { create_default(:group_member, :owner, user: create(:user), group: group ).user }
 
         def get_token
           group.reload.runners_token

spec/requests/api/graphql/mutations/ci/runners_registration_token/reset_spec.rb

@@ -89,7 +89,7 @@ RSpec.describe 'RunnersRegistrationTokenReset' do
     end
 
     include_context 'when authorized', 'group' do
-      let_it_be(:user) { create_default(:group_member, :maintainer, user: create(:user), group: group ).user }
+      let_it_be(:user) { create_default(:group_member, :owner, user: create(:user), group: group ).user }
 
       def get_token
         group.reload.runners_token