Merge branch '10io-fix-nuget-package-file-update-from-metadata' into 'master'

Fix nuget package file update

See merge request gitlab-org/gitlab!24064

ee/app/services/packages/nuget/update_package_from_metadata_service.rb

@@ -17,7 +17,10 @@ module Packages
         raise InvalidMetadataError.new('package name and/or package version not found in metadata') unless valid_metadata?
 
         package_file.transaction do
-          package_file.update!(file_name: package_filename) if package_filename
+          package_file.update!(
+            file_name: package_filename,
+            file: package_file.file
+          )
 
           if existing_package_id
             link_to_existing_package
@@ -74,8 +77,6 @@ module Packages
       end
 
       def package_filename
-        return unless package_name && package_version
-
         "#{package_name.downcase}.#{package_version.downcase}.nupkg"
       end
     end

ee/spec/services/packages/nuget/update_package_from_metadata_service_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe Packages::Nuget::UpdatePackageFromMetadataService do
-  let!(:package) { create(:nuget_package) }
+  let(:package) { create(:nuget_package) }
   let(:package_file) { package.package_files.first }
   let(:service) { described_class.new(package_file) }
   let(:package_name) { 'DummyProject.DummyPackage' }
@@ -13,12 +13,18 @@ describe Packages::Nuget::UpdatePackageFromMetadataService do
   describe '#execute' do
     subject { service.execute }
 
+    before do
+      stub_package_file_object_storage(enabled: true, direct_upload: true)
+    end
+
     it 'updates package and package file' do
       subject
 
       expect(package.reload.name).to eq(package_name)
       expect(package.version).to eq(package_version)
       expect(package_file.reload.file_name).to eq(package_file_name)
+      # hard reset needed to properly reload package_file.file
+      expect(Packages::PackageFile.find(package_file.id).file.size).not_to eq 0
     end
 
     context 'with exisiting package' do