Merge branch '228687-fj-improve-project-create-spec' into 'master'

Improve project feature create spec

See merge request gitlab-org/gitlab!38382

spec/features/projects/snippets/create_snippet_spec.rb

@@ -2,9 +2,28 @@
 
 require 'spec_helper'
 
-RSpec.shared_examples_for 'snippet editor' do
+RSpec.describe 'Projects > Snippets > Create Snippet', :js do
+  include DropzoneHelper
+
+  let_it_be(:user) { create(:user) }
+  let_it_be(:project) do
+    create(:project, :public, creator: user).tap do |p|
+      p.add_maintainer(user)
+    end
+  end
+
+  let(:title) { 'My Snippet Title' }
+  let(:file_content) { 'Hello World!' }
+  let(:md_description) { 'My Snippet **Description**' }
+  let(:description) { 'My Snippet Description' }
+
   before do
+    stub_feature_flags(snippets_vue: false)
     stub_feature_flags(snippets_edit_vue: false)
+
+    sign_in(user)
+
+    visit new_project_snippet_path(project)
   end
 
   def description_field
@@ -12,30 +31,16 @@ RSpec.shared_examples_for 'snippet editor' do
   end
 
   def fill_form
-    fill_in 'project_snippet_title', with: 'My Snippet Title'
+    fill_in 'project_snippet_title', with: title
 
     # Click placeholder first to expand full description field
     description_field.click
-    fill_in 'project_snippet_description', with: 'My Snippet **Description**'
+    fill_in 'project_snippet_description', with: md_description
 
     page.within('.file-editor') do
       el = find('.inputarea')
-      el.send_keys 'Hello World!'
-    end
+      el.send_keys file_content
     end
-
-  context 'when a user is authenticated' do
-    before do
-      stub_feature_flags(snippets_vue: false)
-      project.add_maintainer(user)
-      sign_in(user)
-
-      visit project_snippets_path(project)
-
-      # Wait for the SVG to ensure the button location doesn't shift
-      within('.empty-state') { find('img.js-lazy-loaded') }
-      click_on('New snippet')
-      wait_for_requests
   end
 
   it 'shows collapsible description input' do
@@ -55,10 +60,10 @@ RSpec.shared_examples_for 'snippet editor' do
     click_button('Create snippet')
     wait_for_requests
 
-      expect(page).to have_content('My Snippet Title')
-      expect(page).to have_content('Hello World!')
+    expect(page).to have_content(title)
+    expect(page).to have_content(file_content)
     page.within('.snippet-header .description') do
-        expect(page).to have_content('My Snippet Description')
+      expect(page).to have_content(description)
       expect(page).to have_selector('strong')
     end
   end
@@ -67,7 +72,7 @@ RSpec.shared_examples_for 'snippet editor' do
     fill_form
     dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
 
-      expect(page.find_field("project_snippet_description").value).to have_content('banana_sample')
+    expect(page.find_field('project_snippet_description').value).to have_content('banana_sample')
 
     click_button('Create snippet')
     wait_for_requests
@@ -76,26 +81,12 @@ RSpec.shared_examples_for 'snippet editor' do
     expect(link).to match(%r{/#{Regexp.escape(project.full_path)}/uploads/\h{32}/banana_sample\.gif\z})
   end
 
-    it 'creates a snippet when all required fields are filled in after validation failing' do
-      fill_in 'project_snippet_title', with: 'My Snippet Title'
+  it 'displays validation errors' do
+    fill_in 'project_snippet_title', with: title
     click_button('Create snippet')
-
-      expect(page).to have_selector('#error_explanation')
-
-      fill_form
-      dropzone_file Rails.root.join('spec', 'fixtures', 'banana_sample.gif')
-
-      find("input[value='Create snippet']").send_keys(:return)
     wait_for_requests
 
-      expect(page).to have_content('My Snippet Title')
-      expect(page).to have_content('Hello World!')
-      page.within('.snippet-header .description') do
-        expect(page).to have_content('My Snippet Description')
-        expect(page).to have_selector('strong')
-      end
-      link = find('a.no-attachment-icon img[alt="banana_sample"]')['src']
-      expect(link).to match(%r{/#{Regexp.escape(project.full_path)}/uploads/\h{32}/banana_sample\.gif\z})
+    expect(page).to have_selector('#error_explanation')
   end
 
   context 'when the git operation fails' do
@@ -112,37 +103,9 @@ RSpec.shared_examples_for 'snippet editor' do
       wait_for_requests
     end
 
-      it 'displays the error' do
+    it 'renders the new page and displays the error' do
       expect(page).to have_content(error)
-      end
-
-      it 'renders new page' do
       expect(page).to have_content('New Snippet')
     end
   end
-  end
-
-  context 'when a user is not authenticated' do
-    before do
-      stub_feature_flags(snippets_vue: false)
-    end
-
-    it 'shows a public snippet on the index page but not the New snippet button' do
-      snippet = create(:project_snippet, :public, :repository, project: project)
-
-      visit project_snippets_path(project)
-
-      expect(page).to have_content(snippet.title)
-      expect(page).not_to have_content('New snippet')
-    end
-  end
-end
-
-RSpec.describe 'Projects > Snippets > Create Snippet', :js do
-  include DropzoneHelper
-
-  let_it_be(:user) { create(:user) }
-  let_it_be(:project) { create(:project, :public) }
-
-  it_behaves_like "snippet editor"
 end