An error occurred fetching the project authors.
- 22 Oct, 2021 1 commit
-
-
Thong Kuah authored
This makes it consistent with the cross-db query check. Also it's clearer to use the running spec, instead of the file where the example is defined
-
- 19 Oct, 2021 1 commit
-
-
Thong Kuah authored
Instead of using the filepath where the example is defined, use the filepath where the spec is actually running in. Updates the spec allowlist yml to use real filepath as well
-
- 15 Oct, 2021 1 commit
-
-
Stan Hu authored
We disabled GC due in pg_query to work around https://github.com/pganalyze/pg_query/issues/226, but this turned out to be a bug where the Ruby garbage collector might incorrectly garbage collect an intermediate variable (https://bugs.ruby-lang.org/issues/18140#note-2). https://github.com/pganalyze/pg_query/pull/227 works around the problem by calling to_ary to ensure the Ruby interpreter does not do this. As a result, we can remove the workaround.
-
- 07 Oct, 2021 1 commit
-
-
Grzegorz Bizon authored
-
- 28 Sep, 2021 2 commits
-
-
Kamil Trzciński authored
This uses `#annotate` to indicate that given relation is exempt from cross-join verification check.
-
Dylan Griffith authored
The word modifying is not correct for this as these queries are not necessarily "modifying" anything. I think querying is more accurate.
-
- 07 Sep, 2021 1 commit
-
-
Adam Cohen authored
-
- 01 Sep, 2021 1 commit
-
-
Thong Kuah authored
This fixes this file not known by CI changes rules causing MR pipelines to be "YAML invalid"
-
- 31 Aug, 2021 3 commits
-
-
Thong Kuah authored
-
Thong Kuah authored
Add method to restore check when method ends
-
Thong Kuah authored
But we disable GC around the sql parser to workaround segfault. The segfault looks like it's improperly accessing memory that has been garbage collected.
-
- 30 Aug, 2021 1 commit
-
-
Thong Kuah authored
The use of PgQuery.parse(sql) is causing segfaults so we will disable this for now
-
- 26 Aug, 2021 1 commit
-
-
Dylan Griffith authored
This uses a filename based approach to allowlist spec files Add documentation about cross-database joins detection
-
- 25 Aug, 2021 1 commit
-
-
Thong Kuah authored
-
- 20 Aug, 2021 1 commit
-
-
Kamil Trzciński authored
-
- 13 Aug, 2021 1 commit
-
-
Adam Hegyi authored
-
- 09 Aug, 2021 1 commit
-
-
Dylan Griffith authored
This method can be passed a block and we can validate that no SQL query in that code block attempts to join across ci/main databases. This is useful in the intermediate time while we attempt to fix many small issues until we enable this as the default in all RSpec tests.
-
- 05 Aug, 2021 1 commit
-
-
Kamil Trzciński authored
This adds a test executed as part of specs on each query run on PSQL to be validated if it does cross-joins across databases (main vs ci). This raises exception unless explicitly allowed with a link to the issue.
-