An error occurred fetching the project authors.
  1. 31 Dec, 2019 1 commit
  2. 20 Dec, 2019 1 commit
    • Enrique Alcántara's avatar
      Mock gitlab-ui tooltip directive and component · 06bd4dbd
      Enrique Alcántara authored
      gitlab-ui tooltip component is based on bootstrap-vue tooltip
      component. Starting with bootstrap-vue 2.0, testing Vue components
      that use BV tooltip requires to attach the component under test to the
      document object using vue-test-utils attachToDocument mounting option.
      It also requires setting the `sync` option to true.
      
      This change affected a significant amount of unit tests in GitLab
      codebase. These effects impede GitLab from upgrading to
      bootstrap-vue 2.0. To address this problem we first attempted to fix
      all the affected tests. The list is broken tests is located in
      https://gitlab.com/gitlab-org/gitlab/merge_requests/18913.
      
      Over time, more tests appeared broken as they were using the tooltip
      directive too. The goal to fix broken tests became a moving target,
      so we desisted. This new approach mocks the tooltip directive and
      tooltip component to decouple the unit tests from the bootstrap-vue
      dependency.
      06bd4dbd
  3. 30 Nov, 2019 1 commit
  4. 18 Nov, 2019 1 commit
  5. 06 Nov, 2019 1 commit
    • Martin Hanzel's avatar
      Refactor issuables list to Vue, part 1 · 693f99eb
      Martin Hanzel authored
      ```-----------------
      **WARNING:** This is one of those long commit messages where multiple
      messages are squashed into one
      ```
      
      -----------------
      
      Working: most of the view, bulk edit toggle.
      Not working yet: filtering, bulk edit behaviour.
      
      Enable bulk editing
      
      The bulk edit sidebar is coupled to an issuable's DOM and expects
      the correct information to be there in attributes or dataset.
      
      Add pagination to Vue issuable list
      
      Enable filtering in vue issuables list
      
      Enable label drill-down in vue issuables list
      
      Clicking on a label applies a filter for that label.
      
      Implement sorting and reordering in vue issuable list
      
      Fix edge case in issuable ordering
      
      In the Vue issuables list, the list now takes the sort key from
      the sort dropdown. The server remembers the previous sort state
      even if none is provided in the URL query string, so the
      dropdown is the better source of truth.
      
      Fix a feature flag check
      
      Misc improvements to vue issuable list
      
      - Show only opened issues by default
      - Apply styles for recent and closed issues
      
      Add dates and assignees in vue issue list
      
      - Replace date placeholders with formatted dates
      - Show assignees
      - Add options to issue_assignees.vue for more flexibility
      
      Add empty states to vue issue list
      
      Rename message_queue to pubsub
      
      Update gitlab.pot
      
      Fix a spacing issue
      
      Fix bulk update not working
      
      Update some i18n strings
      
      Add user popovers to vue issuables list
      
      Add tooltips in vue issuables list
      
      Apply review suggestions
      
      Update gitlab pot
      
      Add tests for vue issuables list
      
      - Alter Jest unit test for issue assignees component
      - Add Jest unit tests for issuables list app and issuable
        components
      - Fix rspecs to `wait_for_requests` to allow the Vue app to load
      - Misc fixes to utils and Vue components to fix edge cases
      
      Add eventhub to issueables_list
      
      Add constants to issuebales_list
      
      Add datetime_utility to issueables_list
      
      rm pubsub
      
      Add eventbus to issueable_bulk_update
      
      Add coupling comment to _issue.html.haml
      
      add eventbus and moved constants to new file in issuables list app
      
      bind FF to group
      
      Rm FF guard in JS file when initing issueable list
      
      Replace pubsub with eventbus in spec
      
      get rid of rm .js css class from list
      
      Abstract newDateAsLocal time in issueable
      
      Refactor getting sort from backend
      
      Get sort key from backed and avoid querying the dom more than we need to
      
      Refactor tests to use less snapshots
      
      Add issuable_item and move value to computes
      
      Rm conditional when mounting in issuables_list_app
      
      Replace number with constant to access as prop
      
      Ran prettier on touched files
      
      Fix type in consts
      
      Add group to FF controller
      
      Mv newDateAsLocaleTime to datetime_utility
      
      Mv func to lib/datetime_utility and replace instances in files
      
      Add FF guard to index.js for init component
      
      Rm rspec changes that arent needed
      
      Change storing ids in array to object
      
      Fix bulk edit update all and change how we store ids for a more
      efficient dom interation
      
      Rm issuable_item component
      
      Rm default values undefined
      
      Replace issuable_item component with computed iteration
      
      Refactor issuable spec and snapshot
      
      Get specs passing from addreessing comments
      
      revert style change
      
      run prettier against files
      
      Update issuable_list_app_spec and snapshots
      
      Add shared examples for FF in issue_spec
      
      Move test from issuable_list to issuable
      
      Reset window date after Spec in issuable
      
      Add group to stubbing FF in issues_spec.rb
      
      Run prettier against files
      
      Final patch
      
      Handle refactoring for issuables and issuables list to address bugs
      and spec issues
      693f99eb