Commit 15bec205 authored by ash's avatar ash

Add logging specs for gitlab-keys.

parent 671e86db
...@@ -2,6 +2,10 @@ require_relative 'spec_helper' ...@@ -2,6 +2,10 @@ require_relative 'spec_helper'
require_relative '../lib/gitlab_keys' require_relative '../lib/gitlab_keys'
describe GitlabKeys do describe GitlabKeys do
before do
$logger = double('logger').as_null_object
end
describe :initialize do describe :initialize do
let(:gitlab_keys) { build_gitlab_keys('add-key', 'key-741', 'ssh-rsa AAAAB3NzaDAxx2E') } let(:gitlab_keys) { build_gitlab_keys('add-key', 'key-741', 'ssh-rsa AAAAB3NzaDAxx2E') }
...@@ -18,6 +22,11 @@ describe GitlabKeys do ...@@ -18,6 +22,11 @@ describe GitlabKeys do
gitlab_keys.should_receive(:system).with(valid_cmd) gitlab_keys.should_receive(:system).with(valid_cmd)
gitlab_keys.send :add_key gitlab_keys.send :add_key
end end
it "should log an add-key event" do
$logger.should_receive(:info).with('Adding key key-741 => "ssh-rsa AAAAB3NzaDAxx2E"')
gitlab_keys.send :add_key
end
end end
describe :rm_key do describe :rm_key do
...@@ -28,6 +37,11 @@ describe GitlabKeys do ...@@ -28,6 +37,11 @@ describe GitlabKeys do
gitlab_keys.should_receive(:system).with(valid_cmd) gitlab_keys.should_receive(:system).with(valid_cmd)
gitlab_keys.send :rm_key gitlab_keys.send :rm_key
end end
it "should log an rm-key event" do
$logger.should_receive(:info).with('Removing key key-741')
gitlab_keys.send :rm_key
end
end end
describe :exec do describe :exec do
...@@ -48,6 +62,13 @@ describe GitlabKeys do ...@@ -48,6 +62,13 @@ describe GitlabKeys do
gitlab_keys.should_receive(:puts).with('not allowed') gitlab_keys.should_receive(:puts).with('not allowed')
gitlab_keys.exec gitlab_keys.exec
end end
it 'should log an error on unknown commands' do
gitlab_keys = build_gitlab_keys('nooope')
gitlab_keys.stub(puts: nil)
$logger.should_receive(:error).with('Attempt to execute invalid gitlab-keys command "nooope".')
gitlab_keys.exec
end
end end
def build_gitlab_keys(*args) def build_gitlab_keys(*args)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment