Acknowledge no-op

065f2c7e · Jacob Vosmaer · 5698ebe0 · 065f2c7e
Commit 065f2c7e authored Apr 19, 2017 by Jacob Vosmaer
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 0 deletions

internal/git/git-http.go internal/git/git-http.go +2 -0

No files found.
--- a/internal/git/git-http.go
+++ b/internal/git/git-http.go
@@ -39,6 +39,8 @@ func postRPCHandler(a *api.API, name string, handler func(*GitHttpResponseWriter
 		}()

 		if err := handler(w, r, ar); err != nil {
+			// If the handler already wrote a response this WriteHeader call is a
+			// (harmless) no-op.
 			w.WriteHeader(500)
 			helper.LogError(r, fmt.Errorf("%s: %v", name, err))
 		}