• Daniel Vetter's avatar
    drm/i915: Check mask/bit helper functions · 15a17aae
    Daniel Vetter authored
    After a bit of irc discussion we've concluded that it would be prudent
    to check that callers use the mask/enable paramters correctly. So add
    a WARN_ON.
    
    Spurred by Damien's bugfix which added _MASKED_FIELD.
    
    v2: We use WARN_ON(1) a lot to catch default cases in switch blocks
    which should always be extended. So this doesn't work really. Dunno
    why gcc only started complaining when I've moved the WARN out of the
    static inline helper to address a feedback from Jani.
    
    Cc: Damien Lespiau <damien.lespiau@intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Jani Nikula <jani.nikula@linux.intel.com>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
    15a17aae
i915_irq.c 127 KB