• Jesse Barnes's avatar
    [PATCH] PCI: fix for Toshiba ohci1394 quirk · 6e6ece5d
    Jesse Barnes authored
    After much testing and agony, I've discovered that my previous ohci1394
    quirk for Toshiba laptops is not 100% reliable.  It apparently fails to
    do the interrupt line change either correctly or in time, since in about
    2 out of 5 boots, the kernel's irqdebug code will *still* disable irq 11
    when the ohci1394 driver is loaded (at pci_enable_device time I think).
    
    This patch switches things around a little in the workaround.  First, it
    removes the mdelay.  I didn't see a need for it and my testing has shown
    that it's not necessary for the quirk to work.
    
    Secondly, instead of trying to change the interrupt line to what ACPI
    tells us it should be, this patch makes the quirk use the value in the
    PCI_INTERRUPT_LINE register.  On this laptop at least, that seems to be
    the right thing to do, though additional testing on other laptops and/or
    with actual firewire devices would be appreciated.
    Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    6e6ece5d
fixup.c 14.9 KB