• Oliver O'Halloran's avatar
    powerpc/papr_scm: Fix DIMM device registration race · b0d65a8c
    Oliver O'Halloran authored
    When a new nvdimm device is registered with libnvdimm via
    nvdimm_create() it is added as a device on the nvdimm bus. The probe
    function for the DIMM driver is potentially quite slow so actually
    registering and probing the device is done in an async domain rather
    than immediately after device creation. This can result in a race where
    the region device (created 2nd) is probed first and fails to activate at
    boot.
    
    To fix this we use the same approach as the ACPI/NFIT driver which is to
    check that all the DIMM devices registered successfully. LibNVDIMM
    provides the nvdimm_bus_count_dimms() function which synchronises with
    the async domain and verifies that the dimm was successfully registered
    with the bus.
    
    If either of these does not occur then we bail.
    
    Fixes: b5beae5e ("powerpc/pseries: Add driver for PAPR SCM regions")
    Signed-off-by: default avatarOliver O'Halloran <oohall@gmail.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    b0d65a8c
papr_scm.c 7.94 KB