• Florian Westphal's avatar
    mptcp: fix bogus socket flag values · d99bfed5
    Florian Westphal authored
    Dan Carpenter reports static checker warnings due to bogus BIT() usage:
    
    net/mptcp/subflow.c:571 subflow_write_space() warn: test_bit() takes a bit number
    net/mptcp/subflow.c:694 subflow_state_change() warn: test_bit() takes a bit number
    net/mptcp/protocol.c:261 ssk_check_wmem() warn: test_bit() takes a bit number
    [..]
    
    This is harmless (we use bits 1 & 2 instead of 0 and 1), but would
    break eventually when adding BIT(5) (or 6, depends on size of 'long').
    
    Just use 0 and 1, the values are only passed to test/set/clear_bit
    functions.
    
    Fixes: 648ef4b8 ("mptcp: Implement MPTCP receive path")
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d99bfed5
protocol.h 6.37 KB