• David Windsor's avatar
    cifs: Define usercopy region in cifs_request slab cache · de046449
    David Windsor authored
    CIFS request buffers, stored in the cifs_request slab cache, need to be
    copied to/from userspace.
    
    cache object allocation:
        fs/cifs/cifsfs.c:
            cifs_init_request_bufs():
                ...
                cifs_req_poolp = mempool_create_slab_pool(cifs_min_rcv,
                                                          cifs_req_cachep);
    
        fs/cifs/misc.c:
            cifs_buf_get():
                ...
                ret_buf = mempool_alloc(cifs_req_poolp, GFP_NOFS);
                ...
                return ret_buf;
    
    In support of usercopy hardening, this patch defines a region in the
    cifs_request slab cache in which userspace copy operations are allowed.
    
    This region is known as the slab cache's usercopy region. Slab caches
    can now check that each dynamically sized copy operation involving
    cache-managed memory falls entirely within the slab's usercopy region.
    
    This patch is verbatim from Brad Spengler/PaX Team's PAX_USERCOPY
    whitelisting code in the last public patch of grsecurity/PaX based on my
    understanding of the code. Changes or omissions from the original code are
    mine and don't reflect the original grsecurity/PaX code.
    Signed-off-by: default avatarDavid Windsor <dave@nullcore.net>
    [kees: adjust commit log, provide usage trace]
    Cc: Steve French <sfrench@samba.org>
    Cc: linux-cifs@vger.kernel.org
    Signed-off-by: default avatarKees Cook <keescook@chromium.org>
    de046449
cifsfs.c 38.7 KB