• Arnd Bergmann's avatar
    null_blk: use sector_div instead of do_div · e93d12ae
    Arnd Bergmann authored
    Dividing a sector_t number should be done using sector_div rather than do_div
    to optimize the 32-bit sector_t case, and with the latest do_div optimizations,
    we now get a compile-time warning for this:
    
    arch/arm/include/asm/div64.h:32:95: note: expected 'uint64_t * {aka long long unsigned int *}' but argument is of type 'sector_t * {aka long unsigned int *}'
    drivers/block/null_blk.c:521:81: warning: comparison of distinct pointer types lacks a cast
    
    This changes the newly added code to use sector_div. It is a simplified version
    of the original patch, as Linus Torvalds pointed out that we should not be using
    an expensive division function in the first place.
    
    This version was suggested by Matias Bjorling.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Cc: Matias Bjorling <m@bjorling.me>
    Fixes: b2b7e001 ("null_blk: register as a LightNVM device")
    Signed-off-by: default avatarJens Axboe <axboe@fb.com>
    e93d12ae
null_blk.c 18.8 KB