Commit 0048be9e authored by David Binder's avatar David Binder Committed by Greg Kroah-Hartman

staging: unisys: visorbus: fix commenting in vbusdevinfo.h

This patch ONLY touches comment lines, i.e., NO executable code is
affected.

* All functions worthy of documenting now use standard kerneldoc
  formatting.
* Multi-line comments were tweaked so as to use appropriate conventions.
* Minor typos were corrected.
Signed-off-by: default avatarDavid Binder <david.binder@unisys.com>
Signed-off-by: default avatarTim Sell <Timothy.Sell@unisys.com>
Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Acked-By: default avatarNeil Horman <nhorman@tuxdriver.com>
Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 93e59bfc
...@@ -19,7 +19,8 @@ ...@@ -19,7 +19,8 @@
#pragma pack(push, 1) /* both GCC and VC now allow this pragma */ #pragma pack(push, 1) /* both GCC and VC now allow this pragma */
/* An array of this struct is present in the channel area for each vbus. /*
* An array of this struct is present in the channel area for each vbus.
* (See vbuschannel.h.) * (See vbuschannel.h.)
* It is filled in by the client side to provide info about the device * It is filled in by the client side to provide info about the device
* and driver from the client's perspective. * and driver from the client's perspective.
...@@ -34,19 +35,28 @@ struct ultra_vbus_deviceinfo { ...@@ -34,19 +35,28 @@ struct ultra_vbus_deviceinfo {
#pragma pack(pop) #pragma pack(pop)
/* Reads chars from the buffer at <src> for <srcmax> bytes, and writes to /**
* the buffer at <p>, which is <remain> bytes long, ensuring never to * vbuschannel_sanitize_buffer() - remove non-printable chars from buffer
* overflow the buffer at <p>, using the following rules: * @p: destination buffer where chars are written to
* - printable characters are simply copied from the buffer at <src> to the * @remain: number of bytes that can be written starting at #p
* buffer at <p> * @src: pointer to source buffer
* - intervening streaks of non-printable characters in the buffer at <src> * @srcmax: number of valid characters at #src
* are replaced with a single space in the buffer at <p> *
* Reads chars from the buffer at @src for @srcmax bytes, and writes to
* the buffer at @p, which is @remain bytes long, ensuring never to
* overflow the buffer at @p, using the following rules:
* - printable characters are simply copied from the buffer at @src to the
* buffer at @p
* - intervening streaks of non-printable characters in the buffer at @src
* are replaced with a single space in the buffer at @p
* Note that we pay no attention to '\0'-termination. * Note that we pay no attention to '\0'-termination.
* Returns the number of bytes written to <p>.
* *
* Pass <p> == NULL and <remain> == 0 for this special behavior. In this * Pass @p == NULL and @remain == 0 for this special behavior -- In this
* case, we simply return the number of bytes that WOULD HAVE been written * case, we simply return the number of bytes that WOULD HAVE been written
* to a buffer at <p>, had it been infinitely big. * to a buffer at @p, had it been infinitely big.
*
* Return: the number of bytes written to @p (or WOULD HAVE been written to
* @p, as described in the previous paragraph)
*/ */
static inline int static inline int
vbuschannel_sanitize_buffer(char *p, int remain, char *src, int srcmax) vbuschannel_sanitize_buffer(char *p, int remain, char *src, int srcmax)
...@@ -92,14 +102,18 @@ vbuschannel_sanitize_buffer(char *p, int remain, char *src, int srcmax) ...@@ -92,14 +102,18 @@ vbuschannel_sanitize_buffer(char *p, int remain, char *src, int srcmax)
p++; chars++; remain--; \ p++; chars++; remain--; \
} while (0) } while (0)
/* Converts the non-negative value at <num> to an ascii decimal string /**
* at <p>, writing at most <remain> bytes. Note there is NO '\0' termination * vbuschannel_itoa() - convert non-negative int to string
* written to <p>. * @p: destination string
* @remain: max number of bytes that can be written to @p
* @num: input int to convert
*
* Converts the non-negative value at @num to an ascii decimal string
* at @p, writing at most @remain bytes. Note there is NO '\0' termination
* written to @p.
* *
* Returns the number of bytes written to <p>. * Return: number of bytes written to @p
* *
* Note that we create this function because we need to do this operation in
* an environment-independent way (since we are in a common header file).
*/ */
static inline int static inline int
vbuschannel_itoa(char *p, int remain, int num) vbuschannel_itoa(char *p, int remain, int num)
...@@ -141,13 +155,20 @@ vbuschannel_itoa(char *p, int remain, int num) ...@@ -141,13 +155,20 @@ vbuschannel_itoa(char *p, int remain, int num)
return digits; return digits;
} }
/* Reads <devInfo>, and converts its contents to a printable string at <p>, /**
* writing at most <remain> bytes. Note there is NO '\0' termination * vbuschannel_devinfo_to_string() - format a struct ultra_vbus_deviceinfo
* written to <p>. * to a printable string
* @devinfo: the struct ultra_vbus_deviceinfo to format
* @p: destination string area
* @remain: size of destination string area in bytes
* @devix: the device index to be included in the output data, or -1 if no
* device index is to be included
* *
* Pass <devix> >= 0 if you want a device index presented. * Reads @devInfo, and converts its contents to a printable string at @p,
* writing at most @remain bytes. Note there is NO '\0' termination
* written to @p.
* *
* Returns the number of bytes written to <p>. * Return: number of bytes written to @p
*/ */
static inline int static inline int
vbuschannel_devinfo_to_string(struct ultra_vbus_deviceinfo *devinfo, vbuschannel_devinfo_to_string(struct ultra_vbus_deviceinfo *devinfo,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment