Commit 00a8cdb8 authored by Liu Bo's avatar Liu Bo Committed by Jens Axboe

null_blk: remove NULLB_DEV_FL_CONFIGURED on turning off nullb device

Currently mbps knob could only be set once before switching power knob to
on, after power knob has been set at least once, there is no way to set
mbps knob again due to -EBUSY.

As nullb is mainly used for testing, in order to make it flexible, this
removes the flag NULLB_DEV_FL_CONFIGURED so that mbps knob can be reset
when power knob is off, e.g.

echo 0 > /config/nullb/a/power
echo 40 > /config/nullb/a/mbps
echo 1 > /config/nullb/a/power

So does other knobs under /config/nullb/a.
Signed-off-by: default avatarLiu Bo <bo.liu@linux.alibaba.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent ca47e8c7
...@@ -390,6 +390,7 @@ static ssize_t nullb_device_power_store(struct config_item *item, ...@@ -390,6 +390,7 @@ static ssize_t nullb_device_power_store(struct config_item *item,
null_del_dev(dev->nullb); null_del_dev(dev->nullb);
mutex_unlock(&lock); mutex_unlock(&lock);
clear_bit(NULLB_DEV_FL_UP, &dev->flags); clear_bit(NULLB_DEV_FL_UP, &dev->flags);
clear_bit(NULLB_DEV_FL_CONFIGURED, &dev->flags);
} }
return count; return count;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment