Commit 081192b2 authored by David Daney's avatar David Daney Committed by Linus Torvalds

up.c: use local_irq_{save,restore}() in smp_call_function_single.

The SMP version of this function doesn't unconditionally enable irqs, so
neither should this !SMP version.  There are no know problems caused by
this, but we make the change for consistency's sake.
Signed-off-by: default avatarDavid Daney <david.daney@cavium.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent fa688207
...@@ -10,11 +10,13 @@ ...@@ -10,11 +10,13 @@
int smp_call_function_single(int cpu, void (*func) (void *info), void *info, int smp_call_function_single(int cpu, void (*func) (void *info), void *info,
int wait) int wait)
{ {
unsigned long flags;
WARN_ON(cpu != 0); WARN_ON(cpu != 0);
local_irq_disable(); local_irq_save(flags);
(func)(info); func(info);
local_irq_enable(); local_irq_restore(flags);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment