Commit 0840a90d authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds

exec: simplify ->sighand switching

There is no any reason to do recalc_sigpending() after changing ->sighand.
To begin with, recalc_sigpending() does not take ->sighand into account.

This means we don't need to take newsighand->siglock while changing sighands.
rcu_assign_pointer() provides a necessary barrier, and if another process
reads the new ->sighand it should either take tasklist_lock or it should use
lock_task_sighand() which has a corresponding smp_read_barrier_depends().
Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2b47c361
...@@ -916,12 +916,7 @@ static int de_thread(struct task_struct *tsk) ...@@ -916,12 +916,7 @@ static int de_thread(struct task_struct *tsk)
write_lock_irq(&tasklist_lock); write_lock_irq(&tasklist_lock);
spin_lock(&oldsighand->siglock); spin_lock(&oldsighand->siglock);
spin_lock_nested(&newsighand->siglock, SINGLE_DEPTH_NESTING);
rcu_assign_pointer(tsk->sighand, newsighand); rcu_assign_pointer(tsk->sighand, newsighand);
recalc_sigpending();
spin_unlock(&newsighand->siglock);
spin_unlock(&oldsighand->siglock); spin_unlock(&oldsighand->siglock);
write_unlock_irq(&tasklist_lock); write_unlock_irq(&tasklist_lock);
...@@ -931,12 +926,11 @@ static int de_thread(struct task_struct *tsk) ...@@ -931,12 +926,11 @@ static int de_thread(struct task_struct *tsk)
BUG_ON(!thread_group_leader(tsk)); BUG_ON(!thread_group_leader(tsk));
return 0; return 0;
} }
/* /*
* These functions flushes out all traces of the currently running executable * These functions flushes out all traces of the currently running executable
* so that a new one can be started * so that a new one can be started
*/ */
static void flush_old_files(struct files_struct * files) static void flush_old_files(struct files_struct * files)
{ {
long j = -1; long j = -1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment