Commit 0c42a55c authored by Antti Palosaari's avatar Antti Palosaari Committed by Mauro Carvalho Chehab

[media] em28xx: do not set PCTV 290e LNA handler if fe attach fail

It was a bug that could cause oops if demodulator attach was
failed.
Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a36a66d7
...@@ -1002,20 +1002,22 @@ static int em28xx_dvb_init(struct em28xx *dev) ...@@ -1002,20 +1002,22 @@ static int em28xx_dvb_init(struct em28xx *dev)
result = -EINVAL; result = -EINVAL;
goto out_free; goto out_free;
} }
}
#ifdef CONFIG_GPIOLIB #ifdef CONFIG_GPIOLIB
/* enable LNA for DVB-T, DVB-T2 and DVB-C */ /* enable LNA for DVB-T, DVB-T2 and DVB-C */
result = gpio_request_one(dvb->lna_gpio, GPIOF_OUT_INIT_LOW, result = gpio_request_one(dvb->lna_gpio,
NULL); GPIOF_OUT_INIT_LOW, NULL);
if (result) if (result)
em28xx_errdev("gpio request failed %d\n", result); em28xx_errdev("gpio request failed %d\n",
result);
else else
gpio_free(dvb->lna_gpio); gpio_free(dvb->lna_gpio);
result = 0; /* continue even set LNA fails */ result = 0; /* continue even set LNA fails */
#endif #endif
dvb->fe[0]->ops.set_lna = em28xx_pctv_290e_set_lna; dvb->fe[0]->ops.set_lna = em28xx_pctv_290e_set_lna;
}
break; break;
case EM2884_BOARD_HAUPPAUGE_WINTV_HVR_930C: case EM2884_BOARD_HAUPPAUGE_WINTV_HVR_930C:
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment