Commit 0cb64f02 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab

[media] cx23885: handle errors from videobuf_dvb_get_frontend()

The error handling in the original code wasn't complete so static
checkers complained about a potential NULL deference.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 149709f5
...@@ -1550,7 +1550,6 @@ static int cx23885_set_freq_via_ops(struct cx23885_dev *dev, ...@@ -1550,7 +1550,6 @@ static int cx23885_set_freq_via_ops(struct cx23885_dev *dev,
struct v4l2_control ctrl; struct v4l2_control ctrl;
struct videobuf_dvb_frontend *vfe; struct videobuf_dvb_frontend *vfe;
struct dvb_frontend *fe; struct dvb_frontend *fe;
int err = 0;
struct analog_parameters params = { struct analog_parameters params = {
.mode = V4L2_TUNER_ANALOG_TV, .mode = V4L2_TUNER_ANALOG_TV,
...@@ -1572,8 +1571,10 @@ static int cx23885_set_freq_via_ops(struct cx23885_dev *dev, ...@@ -1572,8 +1571,10 @@ static int cx23885_set_freq_via_ops(struct cx23885_dev *dev,
params.frequency, f->tuner, params.std); params.frequency, f->tuner, params.std);
vfe = videobuf_dvb_get_frontend(&dev->ts2.frontends, 1); vfe = videobuf_dvb_get_frontend(&dev->ts2.frontends, 1);
if (!vfe) if (!vfe) {
err = -EINVAL; mutex_unlock(&dev->lock);
return -EINVAL;
}
fe = vfe->dvb.frontend; fe = vfe->dvb.frontend;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment