Commit 0d81951d authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Jonathan Cameron

iio: magnetometer: mag3110: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200829064726.26268-17-krzk@kernel.orgSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 5d2180ce
...@@ -476,22 +476,14 @@ static int mag3110_probe(struct i2c_client *client, ...@@ -476,22 +476,14 @@ static int mag3110_probe(struct i2c_client *client,
data = iio_priv(indio_dev); data = iio_priv(indio_dev);
data->vdd_reg = devm_regulator_get(&client->dev, "vdd"); data->vdd_reg = devm_regulator_get(&client->dev, "vdd");
if (IS_ERR(data->vdd_reg)) { if (IS_ERR(data->vdd_reg))
if (PTR_ERR(data->vdd_reg) == -EPROBE_DEFER) return dev_err_probe(&client->dev, PTR_ERR(data->vdd_reg),
return -EPROBE_DEFER; "failed to get VDD regulator!\n");
dev_err(&client->dev, "failed to get VDD regulator!\n");
return PTR_ERR(data->vdd_reg);
}
data->vddio_reg = devm_regulator_get(&client->dev, "vddio"); data->vddio_reg = devm_regulator_get(&client->dev, "vddio");
if (IS_ERR(data->vddio_reg)) { if (IS_ERR(data->vddio_reg))
if (PTR_ERR(data->vddio_reg) == -EPROBE_DEFER) return dev_err_probe(&client->dev, PTR_ERR(data->vddio_reg),
return -EPROBE_DEFER; "failed to get VDDIO regulator!\n");
dev_err(&client->dev, "failed to get VDDIO regulator!\n");
return PTR_ERR(data->vddio_reg);
}
ret = regulator_enable(data->vdd_reg); ret = regulator_enable(data->vdd_reg);
if (ret) { if (ret) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment