Commit 0dc220f0 authored by Chuck Lever's avatar Chuck Lever Committed by J. Bruce Fields

SUNRPC: Use unsigned loop and array index in svc_init_buffer()

Clean up: Suppress a harmless compiler warning.

Index rq_pages[] with an unsigned type.  Make "pages" unsigned as well,
as it never represents a value less than zero.
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
parent 50c8bb13
...@@ -510,8 +510,7 @@ EXPORT_SYMBOL(svc_destroy); ...@@ -510,8 +510,7 @@ EXPORT_SYMBOL(svc_destroy);
static int static int
svc_init_buffer(struct svc_rqst *rqstp, unsigned int size) svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
{ {
int pages; unsigned int pages, arghi;
int arghi;
pages = size / PAGE_SIZE + 1; /* extra page as we hold both request and reply. pages = size / PAGE_SIZE + 1; /* extra page as we hold both request and reply.
* We assume one is at most one page * We assume one is at most one page
...@@ -525,7 +524,7 @@ svc_init_buffer(struct svc_rqst *rqstp, unsigned int size) ...@@ -525,7 +524,7 @@ svc_init_buffer(struct svc_rqst *rqstp, unsigned int size)
rqstp->rq_pages[arghi++] = p; rqstp->rq_pages[arghi++] = p;
pages--; pages--;
} }
return ! pages; return pages == 0;
} }
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment