Commit 0ea7efc9 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] direct IO fixes

Some direct IO fixes from Badari Pulavarty.

- off-by-one in the bounds checking in blkdev_get_blocks().

- When adding more blocks into a bio_vec, account for the current
  offset into that bio_vec.

- Fix a total ballsup in the code which calculates the total number
  of pages which are about to be put under IO.
parent 6df888f6
...@@ -105,7 +105,7 @@ static int ...@@ -105,7 +105,7 @@ static int
blkdev_get_blocks(struct inode *inode, sector_t iblock, blkdev_get_blocks(struct inode *inode, sector_t iblock,
unsigned long max_blocks, struct buffer_head *bh, int create) unsigned long max_blocks, struct buffer_head *bh, int create)
{ {
if ((iblock + max_blocks) >= max_block(inode->i_bdev)) if ((iblock + max_blocks) > max_block(inode->i_bdev))
return -EIO; return -EIO;
bh->b_bdev = inode->i_bdev; bh->b_bdev = inode->i_bdev;
......
...@@ -489,7 +489,7 @@ int do_direct_IO(struct dio *dio) ...@@ -489,7 +489,7 @@ int do_direct_IO(struct dio *dio)
/* Work out how much disk we can add to this page */ /* Work out how much disk we can add to this page */
this_chunk_blocks = dio->blocks_available; this_chunk_blocks = dio->blocks_available;
u = (PAGE_SIZE - dio->bvec->bv_len) >> blkbits; u = (PAGE_SIZE - (dio->bvec->bv_offset + dio->bvec->bv_len)) >> blkbits;
if (this_chunk_blocks > u) if (this_chunk_blocks > u)
this_chunk_blocks = u; this_chunk_blocks = u;
u = dio->final_block_in_request - dio->block_in_file; u = dio->final_block_in_request - dio->block_in_file;
...@@ -567,10 +567,11 @@ generic_direct_IO(int rw, struct inode *inode, char *buf, loff_t offset, ...@@ -567,10 +567,11 @@ generic_direct_IO(int rw, struct inode *inode, char *buf, loff_t offset,
dio.curr_page = 0; dio.curr_page = 0;
bytes = count; bytes = count;
dio.total_pages = 0; dio.total_pages = 0;
if (offset & PAGE_SIZE) { if (user_addr & (PAGE_SIZE - 1)) {
dio.total_pages++; dio.total_pages++;
bytes -= PAGE_SIZE - (offset & ~(PAGE_SIZE - 1)); bytes -= PAGE_SIZE - (user_addr & (PAGE_SIZE - 1));
} }
dio.total_pages += (bytes + PAGE_SIZE - 1) / PAGE_SIZE; dio.total_pages += (bytes + PAGE_SIZE - 1) / PAGE_SIZE;
dio.curr_user_address = user_addr; dio.curr_user_address = user_addr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment