Commit 1055b5f9 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Guenter Roeck

hwmon: (coretemp) Allow format checking

By extracting the only part that differs we can allow static checking
of the format string, and possibly save a little .rodata.
Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
[Guenter Roeck: continuation line alignment]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 9eccca08
...@@ -397,14 +397,13 @@ static int create_core_attrs(struct temp_data *tdata, struct device *dev, ...@@ -397,14 +397,13 @@ static int create_core_attrs(struct temp_data *tdata, struct device *dev,
struct device_attribute *devattr, char *buf) = { struct device_attribute *devattr, char *buf) = {
show_label, show_crit_alarm, show_temp, show_tjmax, show_label, show_crit_alarm, show_temp, show_tjmax,
show_ttarget }; show_ttarget };
static const char *const names[TOTAL_ATTRS] = { static const char *const suffixes[TOTAL_ATTRS] = {
"temp%d_label", "temp%d_crit_alarm", "label", "crit_alarm", "input", "crit", "max"
"temp%d_input", "temp%d_crit", };
"temp%d_max" };
for (i = 0; i < tdata->attr_size; i++) { for (i = 0; i < tdata->attr_size; i++) {
snprintf(tdata->attr_name[i], CORETEMP_NAME_LENGTH, names[i], snprintf(tdata->attr_name[i], CORETEMP_NAME_LENGTH,
attr_no); "temp%d_%s", attr_no, suffixes[i]);
sysfs_attr_init(&tdata->sd_attrs[i].dev_attr.attr); sysfs_attr_init(&tdata->sd_attrs[i].dev_attr.attr);
tdata->sd_attrs[i].dev_attr.attr.name = tdata->attr_name[i]; tdata->sd_attrs[i].dev_attr.attr.name = tdata->attr_name[i];
tdata->sd_attrs[i].dev_attr.attr.mode = S_IRUGO; tdata->sd_attrs[i].dev_attr.attr.mode = S_IRUGO;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment