Commit 108feb66 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: cypress_m8.c: remove dbg() tracing calls

dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Lonnie Mendez <dignome@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b627488c
...@@ -305,8 +305,6 @@ static int cypress_serial_control(struct tty_struct *tty, ...@@ -305,8 +305,6 @@ static int cypress_serial_control(struct tty_struct *tty,
const unsigned int feature_len = 5; const unsigned int feature_len = 5;
unsigned long flags; unsigned long flags;
dbg("%s", __func__);
priv = usb_get_serial_port_data(port); priv = usb_get_serial_port_data(port);
if (!priv->comm_is_ok) if (!priv->comm_is_ok)
...@@ -451,8 +449,6 @@ static int generic_startup(struct usb_serial *serial) ...@@ -451,8 +449,6 @@ static int generic_startup(struct usb_serial *serial)
struct cypress_private *priv; struct cypress_private *priv;
struct usb_serial_port *port = serial->port[0]; struct usb_serial_port *port = serial->port[0];
dbg("%s - port %d", __func__, port->number);
priv = kzalloc(sizeof(struct cypress_private), GFP_KERNEL); priv = kzalloc(sizeof(struct cypress_private), GFP_KERNEL);
if (!priv) if (!priv)
return -ENOMEM; return -ENOMEM;
...@@ -505,8 +501,6 @@ static int cypress_earthmate_startup(struct usb_serial *serial) ...@@ -505,8 +501,6 @@ static int cypress_earthmate_startup(struct usb_serial *serial)
struct cypress_private *priv; struct cypress_private *priv;
struct usb_serial_port *port = serial->port[0]; struct usb_serial_port *port = serial->port[0];
dbg("%s", __func__);
if (generic_startup(serial)) { if (generic_startup(serial)) {
dbg("%s - Failed setting up port %d", __func__, dbg("%s - Failed setting up port %d", __func__,
port->number); port->number);
...@@ -537,8 +531,6 @@ static int cypress_hidcom_startup(struct usb_serial *serial) ...@@ -537,8 +531,6 @@ static int cypress_hidcom_startup(struct usb_serial *serial)
{ {
struct cypress_private *priv; struct cypress_private *priv;
dbg("%s", __func__);
if (generic_startup(serial)) { if (generic_startup(serial)) {
dbg("%s - Failed setting up port %d", __func__, dbg("%s - Failed setting up port %d", __func__,
serial->port[0]->number); serial->port[0]->number);
...@@ -556,8 +548,6 @@ static int cypress_ca42v2_startup(struct usb_serial *serial) ...@@ -556,8 +548,6 @@ static int cypress_ca42v2_startup(struct usb_serial *serial)
{ {
struct cypress_private *priv; struct cypress_private *priv;
dbg("%s", __func__);
if (generic_startup(serial)) { if (generic_startup(serial)) {
dbg("%s - Failed setting up port %d", __func__, dbg("%s - Failed setting up port %d", __func__,
serial->port[0]->number); serial->port[0]->number);
...@@ -575,10 +565,7 @@ static void cypress_release(struct usb_serial *serial) ...@@ -575,10 +565,7 @@ static void cypress_release(struct usb_serial *serial)
{ {
struct cypress_private *priv; struct cypress_private *priv;
dbg("%s - port %d", __func__, serial->port[0]->number);
/* all open ports are closed at this point */ /* all open ports are closed at this point */
priv = usb_get_serial_port_data(serial->port[0]); priv = usb_get_serial_port_data(serial->port[0]);
if (priv) { if (priv) {
...@@ -595,8 +582,6 @@ static int cypress_open(struct tty_struct *tty, struct usb_serial_port *port) ...@@ -595,8 +582,6 @@ static int cypress_open(struct tty_struct *tty, struct usb_serial_port *port)
unsigned long flags; unsigned long flags;
int result = 0; int result = 0;
dbg("%s - port %d", __func__, port->number);
if (!priv->comm_is_ok) if (!priv->comm_is_ok)
return -EIO; return -EIO;
...@@ -661,8 +646,6 @@ static void cypress_close(struct usb_serial_port *port) ...@@ -661,8 +646,6 @@ static void cypress_close(struct usb_serial_port *port)
struct cypress_private *priv = usb_get_serial_port_data(port); struct cypress_private *priv = usb_get_serial_port_data(port);
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
/* writing is potentially harmful, lock must be taken */ /* writing is potentially harmful, lock must be taken */
mutex_lock(&port->serial->disc_mutex); mutex_lock(&port->serial->disc_mutex);
if (port->serial->disconnected) { if (port->serial->disconnected) {
...@@ -720,7 +703,6 @@ static void cypress_send(struct usb_serial_port *port) ...@@ -720,7 +703,6 @@ static void cypress_send(struct usb_serial_port *port)
if (!priv->comm_is_ok) if (!priv->comm_is_ok)
return; return;
dbg("%s - port %d", __func__, port->number);
dbg("%s - interrupt out size is %d", __func__, dbg("%s - interrupt out size is %d", __func__,
port->interrupt_out_size); port->interrupt_out_size);
...@@ -828,8 +810,6 @@ static int cypress_write_room(struct tty_struct *tty) ...@@ -828,8 +810,6 @@ static int cypress_write_room(struct tty_struct *tty)
int room = 0; int room = 0;
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
room = kfifo_avail(&priv->write_fifo); room = kfifo_avail(&priv->write_fifo);
spin_unlock_irqrestore(&priv->lock, flags); spin_unlock_irqrestore(&priv->lock, flags);
...@@ -847,8 +827,6 @@ static int cypress_tiocmget(struct tty_struct *tty) ...@@ -847,8 +827,6 @@ static int cypress_tiocmget(struct tty_struct *tty)
unsigned int result = 0; unsigned int result = 0;
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
control = priv->line_control; control = priv->line_control;
status = priv->current_status; status = priv->current_status;
...@@ -874,8 +852,6 @@ static int cypress_tiocmset(struct tty_struct *tty, ...@@ -874,8 +852,6 @@ static int cypress_tiocmset(struct tty_struct *tty,
struct cypress_private *priv = usb_get_serial_port_data(port); struct cypress_private *priv = usb_get_serial_port_data(port);
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
if (set & TIOCM_RTS) if (set & TIOCM_RTS)
priv->line_control |= CONTROL_RTS; priv->line_control |= CONTROL_RTS;
...@@ -948,8 +924,6 @@ static void cypress_set_termios(struct tty_struct *tty, ...@@ -948,8 +924,6 @@ static void cypress_set_termios(struct tty_struct *tty,
__u8 oldlines; __u8 oldlines;
int linechange = 0; int linechange = 0;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
/* We can't clean this one up as we don't know the device type /* We can't clean this one up as we don't know the device type
early enough */ early enough */
...@@ -1096,8 +1070,6 @@ static int cypress_chars_in_buffer(struct tty_struct *tty) ...@@ -1096,8 +1070,6 @@ static int cypress_chars_in_buffer(struct tty_struct *tty)
int chars = 0; int chars = 0;
unsigned long flags; unsigned long flags;
dbg("%s - port %d", __func__, port->number);
spin_lock_irqsave(&priv->lock, flags); spin_lock_irqsave(&priv->lock, flags);
chars = kfifo_len(&priv->write_fifo); chars = kfifo_len(&priv->write_fifo);
spin_unlock_irqrestore(&priv->lock, flags); spin_unlock_irqrestore(&priv->lock, flags);
...@@ -1112,8 +1084,6 @@ static void cypress_throttle(struct tty_struct *tty) ...@@ -1112,8 +1084,6 @@ static void cypress_throttle(struct tty_struct *tty)
struct usb_serial_port *port = tty->driver_data; struct usb_serial_port *port = tty->driver_data;
struct cypress_private *priv = usb_get_serial_port_data(port); struct cypress_private *priv = usb_get_serial_port_data(port);
dbg("%s - port %d", __func__, port->number);
spin_lock_irq(&priv->lock); spin_lock_irq(&priv->lock);
priv->rx_flags = THROTTLED; priv->rx_flags = THROTTLED;
spin_unlock_irq(&priv->lock); spin_unlock_irq(&priv->lock);
...@@ -1126,8 +1096,6 @@ static void cypress_unthrottle(struct tty_struct *tty) ...@@ -1126,8 +1096,6 @@ static void cypress_unthrottle(struct tty_struct *tty)
struct cypress_private *priv = usb_get_serial_port_data(port); struct cypress_private *priv = usb_get_serial_port_data(port);
int actually_throttled, result; int actually_throttled, result;
dbg("%s - port %d", __func__, port->number);
spin_lock_irq(&priv->lock); spin_lock_irq(&priv->lock);
actually_throttled = priv->rx_flags & ACTUALLY_THROTTLED; actually_throttled = priv->rx_flags & ACTUALLY_THROTTLED;
priv->rx_flags = 0; priv->rx_flags = 0;
...@@ -1161,8 +1129,6 @@ static void cypress_read_int_callback(struct urb *urb) ...@@ -1161,8 +1129,6 @@ static void cypress_read_int_callback(struct urb *urb)
int i = 0; int i = 0;
int status = urb->status; int status = urb->status;
dbg("%s - port %d", __func__, port->number);
switch (status) { switch (status) {
case 0: /* success */ case 0: /* success */
break; break;
...@@ -1303,8 +1269,6 @@ static void cypress_write_int_callback(struct urb *urb) ...@@ -1303,8 +1269,6 @@ static void cypress_write_int_callback(struct urb *urb)
int result; int result;
int status = urb->status; int status = urb->status;
dbg("%s - port %d", __func__, port->number);
switch (status) { switch (status) {
case 0: case 0:
/* success */ /* success */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment