Commit 1180e7d6 authored by Michał Mirosław's avatar Michał Mirosław Committed by David S. Miller

net: cleanup vlan_features setting in register_netdev

vlan_features contains features inherited from underlying device.
NETIF_SOFT_FEATURES are not inherited but belong to the vlan device
itself (ensured in vlan_dev_fix_features()).
Signed-off-by: default avatarMichał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6c9c1b54
...@@ -5488,12 +5488,9 @@ int register_netdevice(struct net_device *dev) ...@@ -5488,12 +5488,9 @@ int register_netdevice(struct net_device *dev)
dev->features |= NETIF_F_NOCACHE_COPY; dev->features |= NETIF_F_NOCACHE_COPY;
} }
/* Enable GSO, GRO and NETIF_F_HIGHDMA for vlans by default, /* Make NETIF_F_HIGHDMA inheritable to VLAN devices.
* vlan_dev_fix_features() will do the features check,
* so NETIF_F_HIGHDMA feature is enabled only if supported
* by underlying device.
*/ */
dev->vlan_features |= (NETIF_F_SOFT_FEATURES | NETIF_F_HIGHDMA); dev->vlan_features |= NETIF_F_HIGHDMA;
ret = call_netdevice_notifiers(NETDEV_POST_INIT, dev); ret = call_netdevice_notifiers(NETDEV_POST_INIT, dev);
ret = notifier_to_errno(ret); ret = notifier_to_errno(ret);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment