Commit 168c358a authored by Michael S. Tsirkin's avatar Michael S. Tsirkin

virtio_balloon: fix up endian-ness for free cmd id

free cmd id is read using virtio endian, spec says all fields
in balloon are LE. Fix it up.

Fixes: 86a55978 ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Reviewed-by: default avatarWei Wang <wei.w.wang@intel.com>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
parent ca72cc34
...@@ -578,10 +578,14 @@ static int init_vqs(struct virtio_balloon *vb) ...@@ -578,10 +578,14 @@ static int init_vqs(struct virtio_balloon *vb)
static u32 virtio_balloon_cmd_id_received(struct virtio_balloon *vb) static u32 virtio_balloon_cmd_id_received(struct virtio_balloon *vb)
{ {
if (test_and_clear_bit(VIRTIO_BALLOON_CONFIG_READ_CMD_ID, if (test_and_clear_bit(VIRTIO_BALLOON_CONFIG_READ_CMD_ID,
&vb->config_read_bitmap)) &vb->config_read_bitmap)) {
virtio_cread(vb->vdev, struct virtio_balloon_config, virtio_cread(vb->vdev, struct virtio_balloon_config,
free_page_hint_cmd_id, free_page_hint_cmd_id,
&vb->cmd_id_received_cache); &vb->cmd_id_received_cache);
/* Legacy balloon config space is LE, unlike all other devices. */
if (!virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1))
vb->cmd_id_received_cache = le32_to_cpu((__force __le32)vb->cmd_id_received_cache);
}
return vb->cmd_id_received_cache; return vb->cmd_id_received_cache;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment