Commit 1dbc080c authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Dmitry Torokhov

Input: adxl34x - do not treat FIFO_MODE() as boolean

FIFO_MODE() is a macro expression with a '<<' operator, which gcc points
out could be misread as a '<':

drivers/input/misc/adxl34x.c: In function 'adxl34x_probe':
drivers/input/misc/adxl34x.c:799:36: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context]

While utility of this warning is being disputed (Chief Penguin: "This
warning is clearly pure garbage.") FIFO_MODE() extracts range of values,
with 0 being FIFO_BYPASS, and not something that is logically boolean.

This converts the test to an explicit comparison with FIFO_BYPASS,
making it clearer to gcc and the reader what is intended.

Fixes: e27c7292 ("Input: add driver for ADXL345/346 Digital Accelerometers")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 697c5d8a
...@@ -796,7 +796,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq, ...@@ -796,7 +796,7 @@ struct adxl34x *adxl34x_probe(struct device *dev, int irq,
if (pdata->watermark) { if (pdata->watermark) {
ac->int_mask |= WATERMARK; ac->int_mask |= WATERMARK;
if (!FIFO_MODE(pdata->fifo_mode)) if (FIFO_MODE(pdata->fifo_mode) == FIFO_BYPASS)
ac->pdata.fifo_mode |= FIFO_STREAM; ac->pdata.fifo_mode |= FIFO_STREAM;
} else { } else {
ac->int_mask |= DATA_READY; ac->int_mask |= DATA_READY;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment