Commit 1fbf9d81 authored by Chris Wilson's avatar Chris Wilson

drm/i915: Make default value for i915.mmio_debug a compile time option

The normal behaviour is to periodically check for a mmio access error,
and once detected enable mmio access checking. However this is useless
if the error only occurs once during module load, and so we may miss
such errors in CI. To allow ourselves to catch them, allow CI to opt into
always enabling mmio debugging.
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: default avatarJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190530121311.6794-1-chris@chris-wilson.co.uk
parent f2d13158
...@@ -32,6 +32,7 @@ config DRM_I915_DEBUG ...@@ -32,6 +32,7 @@ config DRM_I915_DEBUG
select DRM_I915_SW_FENCE_DEBUG_OBJECTS select DRM_I915_SW_FENCE_DEBUG_OBJECTS
select DRM_I915_SELFTEST select DRM_I915_SELFTEST
select DRM_I915_DEBUG_RUNTIME_PM select DRM_I915_DEBUG_RUNTIME_PM
select DRM_I915_DEBUG_MMIO
default n default n
help help
Choose this option to turn on extra driver debugging that may affect Choose this option to turn on extra driver debugging that may affect
...@@ -41,6 +42,19 @@ config DRM_I915_DEBUG ...@@ -41,6 +42,19 @@ config DRM_I915_DEBUG
If in doubt, say "N". If in doubt, say "N".
config DRM_I915_DEBUG_MMIO
bool "Always insert extra checks around mmio access by default"
default n
help
By default, always enables the extra sanity checks (extra register
reads) around every mmio (register) access that will slow the system
down. This sets the default value of i915.mmio_debug to -1 and can
be overridden at module load.
Recommended for driver developers only.
If in doubt, say "N".
config DRM_I915_DEBUG_GEM config DRM_I915_DEBUG_GEM
bool "Insert extra checks into the GEM internals" bool "Insert extra checks into the GEM internals"
default n default n
......
...@@ -59,7 +59,7 @@ struct drm_printer; ...@@ -59,7 +59,7 @@ struct drm_printer;
param(char *, guc_firmware_path, NULL) \ param(char *, guc_firmware_path, NULL) \
param(char *, huc_firmware_path, NULL) \ param(char *, huc_firmware_path, NULL) \
param(char *, dmc_firmware_path, NULL) \ param(char *, dmc_firmware_path, NULL) \
param(int, mmio_debug, 0) \ param(int, mmio_debug, -IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO)) \
param(int, edp_vswing, 0) \ param(int, edp_vswing, 0) \
param(int, reset, 2) \ param(int, reset, 2) \
param(unsigned int, inject_load_failure, 0) \ param(unsigned int, inject_load_failure, 0) \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment