Commit 21fc0b9f authored by Eli Billauer's avatar Eli Billauer Committed by Greg Kroah-Hartman

staging: xillybus: Removed write memory barriers before wait_event_*()

According to Documentation/memory-barriers.txt, a memory barrier is put
in place by wait_event_*()
Signed-off-by: default avatarEli Billauer <eli.billauer@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9fdde366
...@@ -634,7 +634,6 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint) ...@@ -634,7 +634,6 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
channel = endpoint->channels[1]; /* This should be generated ad-hoc */ channel = endpoint->channels[1]; /* This should be generated ad-hoc */
channel->wr_sleepy = 1; channel->wr_sleepy = 1;
wmb(); /* Setting wr_sleepy must come before the command */
iowrite32(1 | iowrite32(1 |
(3 << 24), /* Opcode 3 for channel 0 = Send IDT */ (3 << 24), /* Opcode 3 for channel 0 = Send IDT */
...@@ -1968,7 +1967,7 @@ EXPORT_SYMBOL(xillybus_init_endpoint); ...@@ -1968,7 +1967,7 @@ EXPORT_SYMBOL(xillybus_init_endpoint);
static int xilly_quiesce(struct xilly_endpoint *endpoint) static int xilly_quiesce(struct xilly_endpoint *endpoint)
{ {
endpoint->idtlen = -1; endpoint->idtlen = -1;
wmb(); /* Make sure idtlen is set before sending command */
iowrite32((u32) (endpoint->dma_using_dac & 0x0001), iowrite32((u32) (endpoint->dma_using_dac & 0x0001),
endpoint->registers + fpga_dma_control_reg); endpoint->registers + fpga_dma_control_reg);
...@@ -2029,8 +2028,6 @@ int xillybus_endpoint_discovery(struct xilly_endpoint *endpoint) ...@@ -2029,8 +2028,6 @@ int xillybus_endpoint_discovery(struct xilly_endpoint *endpoint)
endpoint->idtlen = -1; endpoint->idtlen = -1;
smp_wmb();
/* /*
* Set DMA 32/64 bit mode, quiesce the device (?!) and get IDT * Set DMA 32/64 bit mode, quiesce the device (?!) and get IDT
* buffer size. * buffer size.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment