Commit 22255bec authored by Mika Westerberg's avatar Mika Westerberg

thunderbolt: Log correct zeroX entries in decode_error()

There was copy & paste error so it always printed value of pkg->zero1.
Also use tb_ctl_warn() here, no need to print backtrace.
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 80e7c5dd
...@@ -219,6 +219,7 @@ static int check_config_address(struct tb_cfg_address addr, ...@@ -219,6 +219,7 @@ static int check_config_address(struct tb_cfg_address addr,
static struct tb_cfg_result decode_error(const struct ctl_pkg *response) static struct tb_cfg_result decode_error(const struct ctl_pkg *response)
{ {
struct cfg_error_pkg *pkg = response->buffer; struct cfg_error_pkg *pkg = response->buffer;
struct tb_ctl *ctl = response->ctl;
struct tb_cfg_result res = { 0 }; struct tb_cfg_result res = { 0 };
res.response_route = tb_cfg_get_route(&pkg->header); res.response_route = tb_cfg_get_route(&pkg->header);
res.response_port = 0; res.response_port = 0;
...@@ -227,9 +228,13 @@ static struct tb_cfg_result decode_error(const struct ctl_pkg *response) ...@@ -227,9 +228,13 @@ static struct tb_cfg_result decode_error(const struct ctl_pkg *response)
if (res.err) if (res.err)
return res; return res;
WARN(pkg->zero1, "pkg->zero1 is %#x\n", pkg->zero1); if (pkg->zero1)
WARN(pkg->zero2, "pkg->zero1 is %#x\n", pkg->zero1); tb_ctl_warn(ctl, "pkg->zero1 is %#x\n", pkg->zero1);
WARN(pkg->zero3, "pkg->zero1 is %#x\n", pkg->zero1); if (pkg->zero2)
tb_ctl_warn(ctl, "pkg->zero2 is %#x\n", pkg->zero2);
if (pkg->zero3)
tb_ctl_warn(ctl, "pkg->zero3 is %#x\n", pkg->zero3);
res.err = 1; res.err = 1;
res.tb_error = pkg->error; res.tb_error = pkg->error;
res.response_port = pkg->port; res.response_port = pkg->port;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment