Commit 230cd127 authored by WANG Cong's avatar WANG Cong Committed by David S. Miller

netpoll: shut up a kernel warning on refcount

When we convert atomic_t to refcount_t, a new kernel warning
on "increment on 0" is introduced in the netpoll code,
zap_completion_queue(). In fact for this special case, we know
the refcount is 0 and we just have to set it to 1 to satisfy
the following dev_kfree_skb_any(), so we can just use
refcount_set(..., 1) instead.

Fixes: 63354797 ("net: convert sk_buff.users from atomic_t to refcount_t")
Reported-by: default avatarDave Jones <davej@codemonkey.org.uk>
Cc: Reshetova, Elena <elena.reshetova@intel.com>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2b02c20c
...@@ -277,7 +277,7 @@ static void zap_completion_queue(void) ...@@ -277,7 +277,7 @@ static void zap_completion_queue(void)
struct sk_buff *skb = clist; struct sk_buff *skb = clist;
clist = clist->next; clist = clist->next;
if (!skb_irq_freeable(skb)) { if (!skb_irq_freeable(skb)) {
refcount_inc(&skb->users); refcount_set(&skb->users, 1);
dev_kfree_skb_any(skb); /* put this one back */ dev_kfree_skb_any(skb); /* put this one back */
} else { } else {
__kfree_skb(skb); __kfree_skb(skb);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment