Commit 23fe8f8b authored by David Rientjes's avatar David Rientjes Committed by Jens Axboe

block, drbd: fix drbd_req_new() initialization

mempool_alloc() does not support __GFP_ZERO since elements may come from
memory that has already been released by mempool_free().

Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly
initialize it to 0.

Cc: Lars Ellenberg <drbd-dev@lists.linbit.com>
Cc: Jens Axboe <axboe@fb.com>
Signed-off-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent ea7618ec
...@@ -52,9 +52,10 @@ static struct drbd_request *drbd_req_new(struct drbd_device *device, ...@@ -52,9 +52,10 @@ static struct drbd_request *drbd_req_new(struct drbd_device *device,
{ {
struct drbd_request *req; struct drbd_request *req;
req = mempool_alloc(drbd_request_mempool, GFP_NOIO | __GFP_ZERO); req = mempool_alloc(drbd_request_mempool, GFP_NOIO);
if (!req) if (!req)
return NULL; return NULL;
memset(req, 0, sizeof(*req));
drbd_req_make_private_bio(req, bio_src); drbd_req_make_private_bio(req, bio_src);
req->rq_state = bio_data_dir(bio_src) == WRITE ? RQ_WRITE : 0; req->rq_state = bio_data_dir(bio_src) == WRITE ? RQ_WRITE : 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment