Commit 2433bea5 authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba

btrfs: reloc: make reloc root search-specific for relocation backref cache

find_reloc_root() searches reloc_control::reloc_root_tree to find the
reloc root.  This behavior is only useful for relocation backref cache.

For the incoming more generic purpose backref cache, we don't care
about who owns the reloc root, but only care if it's a reloc root.

So this patch makes the following modifications to make the reloc root
search more specific to relocation backref:

- Add backref_node::is_reloc_root
  This will be an extra indicator for generic purposed backref cache.
  User doesn't need to read root key from backref_node::root to
  determine if it's a reloc root.
  Also for reloc tree root, it's useless and will be queued to useless
  list.

- Add backref_cache::is_reloc
  This will allow backref cache code to do different behavior for
  generic purpose backref cache and relocation backref cache.

- Pass fs_info to find_reloc_root()

- Export find_reloc_root()
  So backref.c can utilize this function.
Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 33a0f1f7
...@@ -3381,6 +3381,8 @@ void btrfs_reloc_pre_snapshot(struct btrfs_pending_snapshot *pending, ...@@ -3381,6 +3381,8 @@ void btrfs_reloc_pre_snapshot(struct btrfs_pending_snapshot *pending,
int btrfs_reloc_post_snapshot(struct btrfs_trans_handle *trans, int btrfs_reloc_post_snapshot(struct btrfs_trans_handle *trans,
struct btrfs_pending_snapshot *pending); struct btrfs_pending_snapshot *pending);
int btrfs_should_cancel_balance(struct btrfs_fs_info *fs_info); int btrfs_should_cancel_balance(struct btrfs_fs_info *fs_info);
struct btrfs_root *find_reloc_root(struct btrfs_fs_info *fs_info,
u64 bytenr);
/* scrub.c */ /* scrub.c */
int btrfs_scrub_dev(struct btrfs_fs_info *fs_info, u64 devid, u64 start, int btrfs_scrub_dev(struct btrfs_fs_info *fs_info, u64 devid, u64 start,
......
...@@ -122,6 +122,12 @@ struct backref_node { ...@@ -122,6 +122,12 @@ struct backref_node {
* backref node. * backref node.
*/ */
unsigned int detached:1; unsigned int detached:1;
/*
* For generic purpose backref cache, where we only care if it's a reloc
* root, doesn't care the source subvolid.
*/
unsigned int is_reloc_root:1;
}; };
/* /*
...@@ -166,6 +172,14 @@ struct backref_cache { ...@@ -166,6 +172,14 @@ struct backref_cache {
struct list_head useless_node; struct list_head useless_node;
struct btrfs_fs_info *fs_info; struct btrfs_fs_info *fs_info;
/*
* Whether this cache is for relocation
*
* Reloction backref cache require more info for reloc root compared
* to generic backref cache.
*/
unsigned int is_reloc;
}; };
/* /*
...@@ -269,7 +283,7 @@ static void mapping_tree_init(struct mapping_tree *tree) ...@@ -269,7 +283,7 @@ static void mapping_tree_init(struct mapping_tree *tree)
} }
static void backref_cache_init(struct btrfs_fs_info *fs_info, static void backref_cache_init(struct btrfs_fs_info *fs_info,
struct backref_cache *cache) struct backref_cache *cache, int is_reloc)
{ {
int i; int i;
cache->rb_root = RB_ROOT; cache->rb_root = RB_ROOT;
...@@ -281,6 +295,7 @@ static void backref_cache_init(struct btrfs_fs_info *fs_info, ...@@ -281,6 +295,7 @@ static void backref_cache_init(struct btrfs_fs_info *fs_info,
INIT_LIST_HEAD(&cache->pending_edge); INIT_LIST_HEAD(&cache->pending_edge);
INIT_LIST_HEAD(&cache->useless_node); INIT_LIST_HEAD(&cache->useless_node);
cache->fs_info = fs_info; cache->fs_info = fs_info;
cache->is_reloc = is_reloc;
} }
static void backref_cache_cleanup(struct backref_cache *cache) static void backref_cache_cleanup(struct backref_cache *cache)
...@@ -653,13 +668,14 @@ static int should_ignore_root(struct btrfs_root *root) ...@@ -653,13 +668,14 @@ static int should_ignore_root(struct btrfs_root *root)
/* /*
* find reloc tree by address of tree root * find reloc tree by address of tree root
*/ */
static struct btrfs_root *find_reloc_root(struct reloc_control *rc, struct btrfs_root *find_reloc_root(struct btrfs_fs_info *fs_info, u64 bytenr)
u64 bytenr)
{ {
struct reloc_control *rc = fs_info->reloc_ctl;
struct rb_node *rb_node; struct rb_node *rb_node;
struct mapping_node *node; struct mapping_node *node;
struct btrfs_root *root = NULL; struct btrfs_root *root = NULL;
ASSERT(rc);
spin_lock(&rc->reloc_root_tree.lock); spin_lock(&rc->reloc_root_tree.lock);
rb_node = tree_search(&rc->reloc_root_tree.rb_root, bytenr); rb_node = tree_search(&rc->reloc_root_tree.rb_root, bytenr);
if (rb_node) { if (rb_node) {
...@@ -703,6 +719,7 @@ struct backref_node *build_backref_tree(struct reloc_control *rc, ...@@ -703,6 +719,7 @@ struct backref_node *build_backref_tree(struct reloc_control *rc,
{ {
struct btrfs_backref_iter *iter; struct btrfs_backref_iter *iter;
struct backref_cache *cache = &rc->backref_cache; struct backref_cache *cache = &rc->backref_cache;
struct btrfs_fs_info *fs_info = cache->fs_info;
/* For searching parent of TREE_BLOCK_REF */ /* For searching parent of TREE_BLOCK_REF */
struct btrfs_path *path; struct btrfs_path *path;
struct btrfs_root *root; struct btrfs_root *root;
...@@ -825,13 +842,24 @@ struct backref_node *build_backref_tree(struct reloc_control *rc, ...@@ -825,13 +842,24 @@ struct backref_node *build_backref_tree(struct reloc_control *rc,
/* SHARED_BLOCK_REF means key.offset is the parent bytenr */ /* SHARED_BLOCK_REF means key.offset is the parent bytenr */
if (key.type == BTRFS_SHARED_BLOCK_REF_KEY) { if (key.type == BTRFS_SHARED_BLOCK_REF_KEY) {
if (key.objectid == key.offset) { if (key.objectid == key.offset) {
cur->is_reloc_root = 1;
/* Only reloc backref cache cares exact root */
if (cache->is_reloc) {
root = find_reloc_root(fs_info,
cur->bytenr);
if (WARN_ON(!root)) {
err = -ENOENT;
goto out;
}
cur->root = root;
} else {
/* /*
* Only root blocks of reloc trees use backref * For generic purpose backref cache,
* pointing to itself. * reloc root node is useless.
*/ */
root = find_reloc_root(rc, cur->bytenr); list_add(&cur->list,
ASSERT(root); &cache->useless_node);
cur->root = root; }
break; break;
} }
...@@ -4192,7 +4220,7 @@ static struct reloc_control *alloc_reloc_control(struct btrfs_fs_info *fs_info) ...@@ -4192,7 +4220,7 @@ static struct reloc_control *alloc_reloc_control(struct btrfs_fs_info *fs_info)
INIT_LIST_HEAD(&rc->reloc_roots); INIT_LIST_HEAD(&rc->reloc_roots);
INIT_LIST_HEAD(&rc->dirty_subvol_roots); INIT_LIST_HEAD(&rc->dirty_subvol_roots);
backref_cache_init(fs_info, &rc->backref_cache); backref_cache_init(fs_info, &rc->backref_cache, 1);
mapping_tree_init(&rc->reloc_root_tree); mapping_tree_init(&rc->reloc_root_tree);
extent_io_tree_init(fs_info, &rc->processed_blocks, extent_io_tree_init(fs_info, &rc->processed_blocks,
IO_TREE_RELOC_BLOCKS, NULL); IO_TREE_RELOC_BLOCKS, NULL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment