Commit 24d82e34 authored by Kevin Hilman's avatar Kevin Hilman Committed by Paul Walmsley

OMAP: omap_device: when 'called from invalid state', print state

The omap_device_[enable|idle|shutdown] functions print a warning
when called from an invalid state.  Print the invalid state in
the warning messages.  This also uses __func__ to get the function
name.

Also, move the entire print string onto a single line to facilitate
grepping or error messages.  Recent discussions on LKML show
strong preference for grep-able code vs. strict 80 column limit.
Signed-off-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
parent 0007122a
...@@ -466,8 +466,8 @@ int omap_device_enable(struct platform_device *pdev) ...@@ -466,8 +466,8 @@ int omap_device_enable(struct platform_device *pdev)
od = _find_by_pdev(pdev); od = _find_by_pdev(pdev);
if (od->_state == OMAP_DEVICE_STATE_ENABLED) { if (od->_state == OMAP_DEVICE_STATE_ENABLED) {
WARN(1, "omap_device: %s.%d: omap_device_enable() called from " WARN(1, "omap_device: %s.%d: %s() called from invalid state %d\n",
"invalid state\n", od->pdev.name, od->pdev.id); od->pdev.name, od->pdev.id, __func__, od->_state);
return -EINVAL; return -EINVAL;
} }
...@@ -505,8 +505,8 @@ int omap_device_idle(struct platform_device *pdev) ...@@ -505,8 +505,8 @@ int omap_device_idle(struct platform_device *pdev)
od = _find_by_pdev(pdev); od = _find_by_pdev(pdev);
if (od->_state != OMAP_DEVICE_STATE_ENABLED) { if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
WARN(1, "omap_device: %s.%d: omap_device_idle() called from " WARN(1, "omap_device: %s.%d: %s() called from invalid state %d\n",
"invalid state\n", od->pdev.name, od->pdev.id); od->pdev.name, od->pdev.id, __func__, od->_state);
return -EINVAL; return -EINVAL;
} }
...@@ -538,8 +538,8 @@ int omap_device_shutdown(struct platform_device *pdev) ...@@ -538,8 +538,8 @@ int omap_device_shutdown(struct platform_device *pdev)
if (od->_state != OMAP_DEVICE_STATE_ENABLED && if (od->_state != OMAP_DEVICE_STATE_ENABLED &&
od->_state != OMAP_DEVICE_STATE_IDLE) { od->_state != OMAP_DEVICE_STATE_IDLE) {
WARN(1, "omap_device: %s.%d: omap_device_shutdown() called " WARN(1, "omap_device: %s.%d: %s() called from invalid state %d\n",
"from invalid state\n", od->pdev.name, od->pdev.id); od->pdev.name, od->pdev.id, __func__, od->_state);
return -EINVAL; return -EINVAL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment