Commit 250ad590 authored by Ionut Nicu's avatar Ionut Nicu Committed by Wolfram Sang

i2c: mux: gpio: use gpio_set_value_cansleep()

Some gpio chips may have get/set operations that
can sleep. gpio_set_value() only works for chips
which do not sleep, for the others we will get a
kernel warning. Using gpio_set_value_cansleep()
will work for both chips that do sleep and those
who don't.
Signed-off-by: default avatarIonut Nicu <ioan.nicu.ext@nsn.com>
Acked-by: default avatarPeter Korsgaard <peter.korsgaard@barco.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Cc: stable@kernel.org
parent 4edd65e6
...@@ -30,8 +30,8 @@ static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val) ...@@ -30,8 +30,8 @@ static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
int i; int i;
for (i = 0; i < mux->data.n_gpios; i++) for (i = 0; i < mux->data.n_gpios; i++)
gpio_set_value(mux->gpio_base + mux->data.gpios[i], gpio_set_value_cansleep(mux->gpio_base + mux->data.gpios[i],
val & (1 << i)); val & (1 << i));
} }
static int i2c_mux_gpio_select(struct i2c_adapter *adap, void *data, u32 chan) static int i2c_mux_gpio_select(struct i2c_adapter *adap, void *data, u32 chan)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment