Commit 25915302 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

usb: serial: fix memory leak in generic driver

Fix a regression introduced by commit
715b1dc0 ("USB: usb_debug,
usb_generic_serial: implement multi urb write").

URB transfer buffer was never freed when using multi-urb writes. 
Currently the only driver enabling multi-urb writes is usb_debug.
Signed-off-by: default avatarJohan Hovold <jhovold@gmail.com>
Cc: Greg KH <greg@kroah.com>
Acked-by: default avatarJason Wessel <jason.wessel@windriver.com>
Cc: stable <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 25719e6b
...@@ -489,6 +489,8 @@ void usb_serial_generic_write_bulk_callback(struct urb *urb) ...@@ -489,6 +489,8 @@ void usb_serial_generic_write_bulk_callback(struct urb *urb)
dbg("%s - port %d", __func__, port->number); dbg("%s - port %d", __func__, port->number);
if (port->serial->type->max_in_flight_urbs) { if (port->serial->type->max_in_flight_urbs) {
kfree(urb->transfer_buffer);
spin_lock_irqsave(&port->lock, flags); spin_lock_irqsave(&port->lock, flags);
--port->urbs_in_flight; --port->urbs_in_flight;
port->tx_bytes_flight -= urb->transfer_buffer_length; port->tx_bytes_flight -= urb->transfer_buffer_length;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment