Commit 26794942 authored by David Miller's avatar David Miller Committed by David S. Miller

mm: Fix generic hugetlb pte check return type.

The include/asm-generic/hugetlb.h stubs that just vector huge_pte_*()
calls to the pte_*() implementations won't work in certain situations.

x86 and sparc, for example, return "unsigned long" from the bit
checks, and just go "return pte_val(pte) & PTE_BIT_FOO;"

But since huge_pte_*() returns 'int', if any high bits on 64-bit are
relevant, they get chopped off.

The net effect is that we can loop forever trying to COW a huge page,
because the huge_pte_write() check signals false all the time.
Reported-by: default avatarGurudas Pai <gurudas.pai@oracle.com>
Tested-by: default avatarGurudas Pai <gurudas.pai@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
parent 20928bd3
...@@ -6,12 +6,12 @@ static inline pte_t mk_huge_pte(struct page *page, pgprot_t pgprot) ...@@ -6,12 +6,12 @@ static inline pte_t mk_huge_pte(struct page *page, pgprot_t pgprot)
return mk_pte(page, pgprot); return mk_pte(page, pgprot);
} }
static inline int huge_pte_write(pte_t pte) static inline unsigned long huge_pte_write(pte_t pte)
{ {
return pte_write(pte); return pte_write(pte);
} }
static inline int huge_pte_dirty(pte_t pte) static inline unsigned long huge_pte_dirty(pte_t pte)
{ {
return pte_dirty(pte); return pte_dirty(pte);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment