Commit 2a21f869 authored by Dan Carpenter's avatar Dan Carpenter Committed by John W. Linville

wireless: ERR_PTR vs null

iwm_wdev_alloc() returns an ERR_PTR on failure and not null.  It also
prints its own dev_err() message so I removed that as well.

Compile tested only.  Sorry.
Found by smatch (http://repo.or.cz/w/smatch.git).
Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarZhu Yi <yi.zhu@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 45f5fa32
...@@ -106,10 +106,8 @@ void *iwm_if_alloc(int sizeof_bus, struct device *dev, ...@@ -106,10 +106,8 @@ void *iwm_if_alloc(int sizeof_bus, struct device *dev,
int ret = 0; int ret = 0;
wdev = iwm_wdev_alloc(sizeof_bus, dev); wdev = iwm_wdev_alloc(sizeof_bus, dev);
if (!wdev) { if (IS_ERR(wdev))
dev_err(dev, "no memory for wireless device instance\n"); return wdev;
return ERR_PTR(-ENOMEM);
}
iwm = wdev_to_iwm(wdev); iwm = wdev_to_iwm(wdev);
iwm->bus_ops = if_ops; iwm->bus_ops = if_ops;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment