Commit 2a76f89f authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman

firmware: google memconsole: Fix return value check in platform_memconsole_init()

In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().

Fixes: d384d6f4 ("firmware: google memconsole: Add coreboot support")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 856c634d
...@@ -95,8 +95,8 @@ static int __init platform_memconsole_init(void) ...@@ -95,8 +95,8 @@ static int __init platform_memconsole_init(void)
struct platform_device *pdev; struct platform_device *pdev;
pdev = platform_device_register_simple("memconsole", -1, NULL, 0); pdev = platform_device_register_simple("memconsole", -1, NULL, 0);
if (pdev == NULL) if (IS_ERR(pdev))
return -ENODEV; return PTR_ERR(pdev);
platform_driver_register(&memconsole_driver); platform_driver_register(&memconsole_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment