Commit 2a927623 authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Daniel Vetter

drm: fb: cma: fix memory leak

We may have a situation that the memory allocation for fbdefio fails
and then the allocation for fbops may succeed as some memory has been
freed somewhere. Lets free fbops also to face these rare situtation.
Since kfree can handle arguments as NULL, there should not be any
problem in calling both the kfree().
Signed-off-by: default avatarSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Fixes: 199c7717 ("drm/fb-cma-helper: Add fb_deferred_io support")
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1465743836-6228-1-git-send-email-sudipm.mukherjee@gmail.com
parent cc22a86c
...@@ -346,6 +346,7 @@ static int drm_fbdev_cma_defio_init(struct fb_info *fbi, ...@@ -346,6 +346,7 @@ static int drm_fbdev_cma_defio_init(struct fb_info *fbi,
fbops = kzalloc(sizeof(*fbops), GFP_KERNEL); fbops = kzalloc(sizeof(*fbops), GFP_KERNEL);
if (!fbdefio || !fbops) { if (!fbdefio || !fbops) {
kfree(fbdefio); kfree(fbdefio);
kfree(fbops);
return -ENOMEM; return -ENOMEM;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment