Commit 2b13d06c authored by Salva Peiró's avatar Salva Peiró Committed by David S. Miller

wanxl: fix info leak in ioctl

The wanxl_ioctl() code fails to initialize the two padding bytes of
struct sync_serial_settings after the ->loopback member. Add an explicit
memset(0) before filling the structure to avoid the info leak.
Signed-off-by: default avatarSalva Peiró <speiro@ai2.upv.es>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b8bde1c4
...@@ -355,6 +355,7 @@ static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) ...@@ -355,6 +355,7 @@ static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
ifr->ifr_settings.size = size; /* data size wanted */ ifr->ifr_settings.size = size; /* data size wanted */
return -ENOBUFS; return -ENOBUFS;
} }
memset(&line, 0, sizeof(line));
line.clock_type = get_status(port)->clocking; line.clock_type = get_status(port)->clocking;
line.clock_rate = 0; line.clock_rate = 0;
line.loopback = 0; line.loopback = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment