Commit 2b60c49f authored by Lukas Wunner's avatar Lukas Wunner Committed by Mark Brown

spi: amd: Fix duplicate iounmap in error path

The AMD SPI driver uses devm_ioremap_resource() to map its registers, so
they're automatically unmapped via device_release() when the last ref on
the SPI controller is dropped.  The additional iounmap() in the ->probe()
error path is thus unnecessary.
Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/497cc38ae2beb7900ae05a1463eb83ff96e2770e.1588590210.git.lukas@wunner.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent b68527df
...@@ -285,14 +285,12 @@ static int amd_spi_probe(struct platform_device *pdev) ...@@ -285,14 +285,12 @@ static int amd_spi_probe(struct platform_device *pdev)
err = spi_register_master(master); err = spi_register_master(master);
if (err) { if (err) {
dev_err(dev, "error %d registering SPI controller\n", err); dev_err(dev, "error %d registering SPI controller\n", err);
goto err_iounmap; goto err_free_master;
} }
platform_set_drvdata(pdev, amd_spi); platform_set_drvdata(pdev, amd_spi);
return 0; return 0;
err_iounmap:
iounmap(amd_spi->io_remap_addr);
err_free_master: err_free_master:
spi_master_put(master); spi_master_put(master);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment