Commit 2ccb4f16 authored by Nicolin Chen's avatar Nicolin Chen Committed by Guenter Roeck

hwmon: (ina3221) Fix read timeout issue

After introducing "samples" to the calculation of wait time, the
driver might timeout at the regmap_field_read_poll_timeout call,
because the wait time could be longer than the 100000 usec limit
due to a large "samples" number.

So this patch sets the timeout limit to 2 times of the wait time
in order to fix this issue.

Fixes: 5c090abf ("hwmon: (ina3221) Add averaging mode support")
Signed-off-by: default avatarNicolin Chen <nicoleotsuka@gmail.com>
Link: https://lore.kernel.org/r/20191022005922.30239-1-nicoleotsuka@gmail.comSigned-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 6fc28b7e
...@@ -170,7 +170,7 @@ static inline int ina3221_wait_for_data(struct ina3221_data *ina) ...@@ -170,7 +170,7 @@ static inline int ina3221_wait_for_data(struct ina3221_data *ina)
/* Polling the CVRF bit to make sure read data is ready */ /* Polling the CVRF bit to make sure read data is ready */
return regmap_field_read_poll_timeout(ina->fields[F_CVRF], return regmap_field_read_poll_timeout(ina->fields[F_CVRF],
cvrf, cvrf, wait, 100000); cvrf, cvrf, wait, wait * 2);
} }
static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg, static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment