Commit 2d1c4cf1 authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck

hwmon: (smsc47m192) use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO for read only attributes and DEVICE_ATTR_RW for
read/write attributes. This simplifies the source code, improves
readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 83aa233e
...@@ -400,22 +400,22 @@ show_temp_index(2) ...@@ -400,22 +400,22 @@ show_temp_index(2)
show_temp_index(3) show_temp_index(3)
/* VID */ /* VID */
static ssize_t show_vid(struct device *dev, struct device_attribute *attr, static ssize_t cpu0_vid_show(struct device *dev,
char *buf) struct device_attribute *attr, char *buf)
{ {
struct smsc47m192_data *data = smsc47m192_update_device(dev); struct smsc47m192_data *data = smsc47m192_update_device(dev);
return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm)); return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
} }
static DEVICE_ATTR(cpu0_vid, S_IRUGO, show_vid, NULL); static DEVICE_ATTR_RO(cpu0_vid);
static ssize_t show_vrm(struct device *dev, struct device_attribute *attr, static ssize_t vrm_show(struct device *dev, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct smsc47m192_data *data = dev_get_drvdata(dev); struct smsc47m192_data *data = dev_get_drvdata(dev);
return sprintf(buf, "%d\n", data->vrm); return sprintf(buf, "%d\n", data->vrm);
} }
static ssize_t set_vrm(struct device *dev, struct device_attribute *attr, static ssize_t vrm_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count) const char *buf, size_t count)
{ {
struct smsc47m192_data *data = dev_get_drvdata(dev); struct smsc47m192_data *data = dev_get_drvdata(dev);
...@@ -431,7 +431,7 @@ static ssize_t set_vrm(struct device *dev, struct device_attribute *attr, ...@@ -431,7 +431,7 @@ static ssize_t set_vrm(struct device *dev, struct device_attribute *attr,
data->vrm = val; data->vrm = val;
return count; return count;
} }
static DEVICE_ATTR(vrm, S_IRUGO | S_IWUSR, show_vrm, set_vrm); static DEVICE_ATTR_RW(vrm);
/* Alarms */ /* Alarms */
static ssize_t show_alarm(struct device *dev, struct device_attribute *attr, static ssize_t show_alarm(struct device *dev, struct device_attribute *attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment